映射文档 No. 34 #5825
Closed
映射文档 No. 34 #5825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
感谢你贡献飞桨文档，文档预览构建中，Docs-New 跑完后即可预览，预览链接：http://preview-pr-5825.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html |
|
您好，请您check一下PR@Tomoko-hjf |
| | dim | axis | 表示在哪一个维度 scatter ，仅参数名不一致。 | | ||
| | index | indices | 表示输入的索引张量，仅参数名不一致。 | | ||
| | src | values | 表示需要插入的值，仅参数名不一致。 | | ||
| | reduce | reduce | 表示对输出 Tensor 的计算方式，与 PyTorch 默认值不同+ Paddle 保持默认即可。 | |
There was a problem hiding this comment.
这里如果不指定的话都是直接覆盖吧，所以只写 表示对输出 Tensor 的计算方式。就可以
| | dim | axis | 表示在哪一个维度 scatter ，仅参数名不一致。 | | ||
| | index | indices | 表示输入的索引张量，仅参数名不一致。 | | ||
| | src | values | 表示需要插入的值，仅参数名不一致。 | | ||
| | - | reduce | 表示对输出 Tensor 的计算方式， PyTorch 无此参数+ Paddle 应设置为 add 。 | |
| reduce='assign') | ||
| ``` | ||
|
|
||
| 两者功能一致且参数用法一致，仅参数名不同，同时 Paddle 支持更多其他参数，具体如下： |
There was a problem hiding this comment.
这句话直接写 Paddle 相比 Pytorch 支持更多其他参数，具体如下：就可以
| ### [torch.scatter_add](https://pytorch.org/docs/1.13/generated/torch.scatter_add.html#torch.scatter_add) | ||
|
|
||
| ```python | ||
| torch.scatter(input, |
| | dim | axis | 表示在哪一个维度 scatter ，仅参数名不一致。 | | ||
| | index | indices | 表示输入的索引张量，仅参数名不一致。 | | ||
| | src | values | 表示需要插入的值，仅参数名不一致。 | | ||
| | - | reduce | 表示对输出 Tensor 的计算方式， PyTorch 无此参数+ Paddle 应设置此参数为 add 。| |
|
好多地方都没有修改，点击files可以看到评论吗 |
cccbbbttt
force-pushed
the
my-cool-stuff
branch
from
28c67ec
to
d5cf951
Compare
|
修改了，请您看还有问题吗@ Tomoko-hjf |
|
@zhwesky2010 ，请问可以合并PR吗 |
|
@Tomoko-hjf，请问可以合并PR吗 |
zhwesky2010
reviewed
May 12, 2023
|
|
||
| ```python | ||
| paddle.Tensor.put_along_axis_(indices, | ||
| value, |
|
|
||
| ```python | ||
| paddle.Tensor.put_along_axis_(indices, | ||
| value, |
| | dim | axis | 表示在哪一个维度 scatter ，仅参数名不一致。 | | ||
| | index | indices | 表示输入的索引张量，仅参数名不一致。 | | ||
| | src | values | 表示需要插入的值，仅参数名不一致。 | | ||
| | - | reduce | 表示对输出 Tensor 的计算方式， PyTorch 无此参数, Paddle 应设置为 add 。 | |
There was a problem hiding this comment.
这两个API对比了结果没，应该不是完全一致的
| | dim | axis | 表示在哪一个维度 scatter ，仅参数名不一致。 | | ||
| | index | indices | 表示输入的索引张量，仅参数名不一致。 | | ||
| | src | values | 表示需要插入的值，仅参数名不一致。 | | ||
| | - | reduce | 表示对输出 Tensor 的计算方式， PyTorch 无此参数, Paddle 应设置此参数为 add 。| |
There was a problem hiding this comment.
这两个映射对比下结果是否一致吧，put_along_axis可以映射到scatter，但是scatter_add可能还需要组合其他的逻辑
|
@cccbbbttt 同学你好，有时间的话可以按照修改意见完善一下映射文档~ |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update md