映射文档 No.44 #5827

TzssZ · 2023-04-24T04:07:15Z

分组 ID 44

paddle-bot · 2023-04-24T04:07:19Z

感谢你贡献飞桨文档，文档预览构建中，Docs-New 跑完后即可预览，预览链接：http://preview-pr-5827.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html
预览工具的更多说明，请参考：飞桨文档预览工具

TzssZ · 2023-04-24T08:28:36Z

你好，我对分组ID 44（#5691）中的9个api进行了映射，其中torch.kthvalue已经存在，我就没有进行改动了。

huajiao-hjyp

有两个公共的小问题，辛苦修改一下~

备注完善一下，参数名不一致的加一句仅参数名不一致。
out的转写用 paddle.assign实现

huajiao-hjyp · 2023-04-24T09:04:56Z

docs/guides/model_convert/convert_from_pytorch/api_difference/ops/torch.fmax.md

+### 参数映射
+| PyTorch       | PaddlePaddle | 备注                                                   |
+| ------------- | ------------ | ------------------------------------------------------ |
+| input         | x            | 输入的 Tensor。数据类型为 float16 、 float32 、 float64 、 int32 或 int64。|


辛苦备注加一句 仅参数名不一致。 ~

huajiao-hjyp · 2023-04-24T09:05:21Z

docs/guides/model_convert/convert_from_pytorch/api_difference/ops/torch.fmax.md

+| PyTorch       | PaddlePaddle | 备注                                                   |
+| ------------- | ------------ | ------------------------------------------------------ |
+| input         | x            | 输入的 Tensor。数据类型为 float16 、 float32 、 float64 、 int32 或 int64。|
+| other         | y            | 输入的 Tensor。数据类型为 float16 、 float32 、 float64 、 int32 或 int64。  |


备注加一句 仅参数名不一致。

huajiao-hjyp · 2023-04-24T09:06:20Z

docs/guides/model_convert/convert_from_pytorch/api_difference/ops/torch.fmax.md

+torch.fmax([3, 5], 1., out=y)
+
+# Paddle 写法
+y = paddle.fmax([3, 5], 1.)


这里的转写应该是借助paddle.assign实现，可以参考 https://github.com/PaddlePaddle/docs/blob/develop/docs/guides/model_convert/convert_from_pytorch/api_difference/pytorch_api_mapping_format_cn.md#out%E6%8C%87%E5%AE%9A%E8%BE%93%E5%87%BA

huajiao-hjyp · 2023-04-24T09:07:05Z

docs/guides/model_convert/convert_from_pytorch/api_difference/ops/torch.fmin.md

+| PyTorch       | PaddlePaddle | 备注                                                   |
+| ------------- | ------------ | ------------------------------------------------------ |
+| input         | x            | 输入的 Tensor。数据类型为 float16 、 float32 、 float64 、 int32 或 int64。|
+| other         | y            | 输入的 Tensor。数据类型为 float16 、 float32 、 float64 、 int32 或 int64。  |


备注加一句仅参数名不一致。

huajiao-hjyp · 2023-04-24T09:08:01Z

docs/guides/model_convert/convert_from_pytorch/api_difference/ops/torch.fmin.md

+torch.fmin([3, 5], 1., out=y)
+
+# Paddle 写法
+y = paddle.fmin([3, 5], 1.)


转写应该为 paddle.assign(paddle.fmin([3, 5], 1.), y)

huajiao-hjyp · 2023-04-24T09:09:20Z

docs/guides/model_convert/convert_from_pytorch/api_difference/ops/torch.greater.md

+torch.greater([3, 5], 1., out=y)
+
+# Paddle 写法
+y = paddle.greater_than([3, 5], 1.)


转写方式

huajiao-hjyp · 2023-04-24T09:09:49Z

docs/guides/model_convert/convert_from_pytorch/api_difference/ops/torch.le.md

+| PyTorch       | PaddlePaddle | 备注                                                   |
+| ------------- | ------------ | ------------------------------------------------------ |
+| input         | x            | 输入 Tensor，支持的数据类型包括 bool、float32、float64、int32、int64。 |
+| other         | y            | 输入 Tensor，支持的数据类型包括 bool、float32、float64、int32、int64。  |


备注完善一下~

huajiao-hjyp · 2023-04-24T09:10:24Z

docs/guides/model_convert/convert_from_pytorch/api_difference/ops/torch.le.md

+torch.le([3, 5], 1., out=y)
+
+# Paddle 写法
+y = paddle.less_equal([3, 5], 1.)


转写修改一下~

huajiao-hjyp · 2023-04-24T09:10:55Z

docs/guides/model_convert/convert_from_pytorch/api_difference/ops/torch.less.md

+| PyTorch       | PaddlePaddle | 备注                                                   |
+| ------------- | ------------ | ------------------------------------------------------ |
+| input         | x            | 输入 Tensor，支持的数据类型包括 bool、float32、float64、int32、int64。 |
+| other         | y            | 输入 Tensor，支持的数据类型包括 bool、float32、float64、int32、int64。  |


备注完善一下~

huajiao-hjyp · 2023-04-24T09:11:10Z

docs/guides/model_convert/convert_from_pytorch/api_difference/ops/torch.less.md

+torch.less([3, 5], 1., out=y)
+
+# Paddle 写法
+y = paddle.less_than([3, 5], 1.)


转写方式修改一下

不好意思，我重新按照要求完善了备注和改写方式，感谢

TzssZ · 2023-04-24T10:25:30Z

不好意思，我重新按照要求完善了备注和改写方式，麻烦了

huajiao-hjyp

LGTM

huajiao-hjyp · 2023-04-24T11:28:45Z

CI 没有过，需要按照官网安装一下pre-commit，https://www.paddlepaddle.org.cn/documentation/docs/zh/dev_guides/code_contributing_path_cn.html

TzssZ · 2023-04-24T12:40:04Z

你好，我按照官网安装了pre-commit并重新提交了，也按照官网要求完善了简化了参数备注

huajiao-hjyp

LGTM

zhwesky2010 · 2023-04-25T09:29:17Z

docs/guides/model_convert/convert_from_pytorch/api_difference/ops/torch.maximum.md

@@ -0,0 +1,32 @@
+## [torch 参数更多 ]torch.maximum


maximum/minimum应该已经有了

好的，那是需要删除后再提交还是选择直接合并呢？

TzssZ · 2023-05-01T04:29:03Z

你好，maximum/minimum这两个我在映射时还没有，请问现在需要我怎么处理？

huajiao-hjyp · 2023-05-01T08:00:36Z

你好，maximum/minimum这两个我在映射时还没有，请问现在需要我怎么处理？

你好，确认了一下这两个文件目前还没有，继续保留就可以，我们会进行merge~

TzssZ · 2023-05-03T06:49:22Z

好的，麻烦了

zhwesky2010 · 2023-05-08T10:01:26Z

docs/guides/model_convert/convert_from_pytorch/api_difference/ops/torch.greater.md

+#### out：指定输出
+```python
+# Pytorch 写法
+torch.greater([3, 5], 1., out=y)


换一个两个shape一致的吧，目前paddle还不支持第二个参数为scalar

zhwesky2010 · 2023-05-08T10:01:52Z

docs/guides/model_convert/convert_from_pytorch/api_difference/ops/torch.less.md

+#### out：指定输出
+```python
+# Pytorch 写法
+torch.less([3, 5], 1., out=y)


换成shape为一致的case

zhwesky2010 · 2023-05-08T10:02:02Z

docs/guides/model_convert/convert_from_pytorch/api_difference/ops/torch.less_equal.md

+#### out：指定输出
+```python
+# Pytorch 写法
+torch.less_equal([3, 5], 1., out=y)


换成shape为一致的case

zhwesky2010 · 2023-05-08T10:02:11Z

docs/guides/model_convert/convert_from_pytorch/api_difference/ops/torch.lt.md

+#### out：指定输出
+```python
+# Pytorch 写法
+torch.lt([3, 5], 1., out=y)


换成shape为一致的case

zhwesky2010 · 2023-05-08T10:04:34Z

docs/guides/model_convert/convert_from_pytorch/api_difference/ops/torch.maximum.md

+#### out：指定输出
+```python
+# Pytorch 写法
+torch.maximum([3, 5], 1., out=y)


换成shape为一致的case

zhwesky2010 · 2023-05-08T10:04:37Z

docs/guides/model_convert/convert_from_pytorch/api_difference/ops/torch.minimum.md

+#### out：指定输出
+```python
+# Pytorch 写法
+torch.minimum([3, 5], 1., out=y)


换成shape为一致的case

你好，我已按照要求修改相关问题了

TzssZ · 2023-05-09T04:16:25Z

你好，我已按照要求修改相关问题了

TzssZ · 2023-05-09T05:04:39Z

@zhwesky2010

zhwesky2010

LGTM

luotao1 · 2023-05-16T07:16:07Z

hi, @TzssZ

非常感谢你对飞桨框架的贡献，我们正在运营一个PFCC组织，会通过定期分享技术知识与发布开发者主导任务的形式持续为飞桨框架做贡献，详情可见 https://github.com/luotao1 主页说明。
如果你对PFCC有兴趣，请发送邮件至 ext_paddle_oss@baidu.com，我们会邀请你加入~

映射文档 No.44

8e9d75e

paddle-bot bot added contributor status: proposed labels Apr 24, 2023

huajiao-hjyp mentioned this pull request Apr 24, 2023

PyTorch 1.13 与 Paddle 2.4 API 映射文档开源任务 #5691

Closed

luotao1 assigned zhwesky2010 and huajiao-hjyp Apr 24, 2023

映射文档 No.44

988454b

TzssZ changed the title ~~[work in process]映射文档 No.44~~ 映射文档 No.44 Apr 24, 2023

huajiao-hjyp reviewed Apr 24, 2023

View reviewed changes

映射文档 No.44:完善参数备注和转写方式

28b2fde

huajiao-hjyp approved these changes Apr 24, 2023

View reviewed changes

映射文档 No.44:完善备注和处理CI问题

0f4823c

huajiao-hjyp approved these changes Apr 25, 2023

View reviewed changes

zhwesky2010 reviewed Apr 25, 2023

View reviewed changes

zhwesky2010 reviewed May 8, 2023

View reviewed changes

换成shape为一致的case

1c5d675

zhwesky2010 approved these changes May 12, 2023

View reviewed changes

zhwesky2010 merged commit 0e63fa0 into PaddlePaddle:develop May 12, 2023

luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Aug 15, 2023

映射文档 No.44 #5827

映射文档 No.44 #5827

Conversation

TzssZ commented Apr 24, 2023

paddle-bot bot commented Apr 24, 2023

TzssZ commented Apr 24, 2023

huajiao-hjyp left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TzssZ commented Apr 24, 2023

huajiao-hjyp left a comment

Choose a reason for hiding this comment

huajiao-hjyp commented Apr 24, 2023

TzssZ commented Apr 24, 2023

huajiao-hjyp left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TzssZ commented May 1, 2023

huajiao-hjyp commented May 1, 2023

TzssZ commented May 3, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TzssZ commented May 9, 2023

TzssZ commented May 9, 2023

zhwesky2010 left a comment

Choose a reason for hiding this comment

luotao1 commented May 16, 2023