Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] 添加监测中文 apilabel 的 ci #6226

Merged
merged 29 commits into from
Oct 22, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ci_scripts/check_api_label_cn.py
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉像是一坨,先提一下

没关系,咱代码风格可以慢慢锻炼,这个多写写就好了,而且还有我来把控~而且比某些写了一坨还不自知的人强太多了(这个 repo 能成这样,所有代码 reviewer 都有责任)

Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ def find_api_labels_in_one_file(file_path):
def should_test(file):
return (
file.endswith("_cn.rst")
and (file not in ["Overview_cn.rst", "index_cn.rst"])
and not file.endswith("Overview_cn.rst")
and not file.endswith("index_cn.rs")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为啥是 .rs?rust 代码么 [doge]

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[doge] t 走丢了,过会就回来

and file.startswith(API)
)

Expand Down