Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Hackathon No.8】add docs for api hypot & hypot_ #6230

Merged
merged 6 commits into from
Oct 19, 2023

Conversation

llyyxx0413
Copy link
Contributor

@llyyxx0413 llyyxx0413 commented Oct 17, 2023

add docs for api hypot & hypot_

@paddle-bot
Copy link

paddle-bot bot commented Oct 17, 2023

感谢你贡献飞桨文档,文档预览构建中,Docs-New 跑完后即可预览,预览链接:http://preview-pr-6230.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html
预览工具的更多说明,请参考:飞桨文档预览工具

Copy link
Collaborator

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 缺少 inplace 版本的中文文档。
  • 文档撰写请务必认真对待,提交 PR 前先 check 一遍是否有显而易见的 typo。

Comment on lines 1 to 3
.. _cn_api_paddle_i0:

i0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这两处都改成 hypot

`hypot` 函数对于给定直角三角形直角边 `x`, `y` 实现斜边长度求解的计算;

.. math::
out= \sqrt{x^2 + y^2} $$
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修改一下公式语法,后面多了 $$
image

Comment on lines 16 to 17
- **x** (Tensor) – 输入Tensor,它的数据类型可以是 float32,float64, int32, int6。
- **x** (Tensor) – 输入 Tensor,它的数据类型可以是 float32,float64,int32, int64。
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **x** (Tensor) – 输入Tensor,它的数据类型可以是 float32,float64, int32, int6
- **x** (Tensor) – 输入 Tensor,它的数据类型可以是 float32,float64,int32, int64。
- **x** (Tensor) – 输入Tensor,它的数据类型可以是 float32,float64int32,int64
- **y** (Tensor) – 输入 Tensor,它的数据类型可以是 float32,float64int32int64。

@luotao1
Copy link
Collaborator

luotao1 commented Oct 18, 2023

缺少 inplace 版本的中文文档。

@llyyxx0413 可以参考下 clip_ 补充

@luotao1 luotao1 closed this Oct 19, 2023
@luotao1 luotao1 reopened this Oct 19, 2023
@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Oct 19, 2023
@PaddlePaddle PaddlePaddle unlocked this conversation Oct 19, 2023
Copy link
Collaborator

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit b757028 into PaddlePaddle:develop Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants