Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] fix docker relative doc when build from source #6469

Merged
merged 1 commit into from
Jan 15, 2024
Merged

[Fix] fix docker relative doc when build from source #6469

merged 1 commit into from
Jan 15, 2024

Conversation

cocoshe
Copy link
Contributor

@cocoshe cocoshe commented Jan 14, 2024

  1. 主要更新了一下源码编译安装的docker部分,原先的nvidia-docker已弃用,被NVIDIA Container Toolkit取代。

image

  1. 另外更新了一下doc中的镜像版本,稍旧版本的镜像可能会有编译相关问题:

Copy link

paddle-bot bot commented Jan 14, 2024

感谢你贡献飞桨文档,文档预览构建中,Docs-New 跑完后即可预览,预览链接:http://preview-pr-6469.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html
预览工具的更多说明,请参考:飞桨文档预览工具

@cocoshe cocoshe changed the title fix docker relative doc when build from source [Fix] fix docker relative doc when build from source Jan 14, 2024
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Jan 15, 2024
Copy link
Collaborator

@tianshuo78520a tianshuo78520a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@risemeup1 risemeup1 merged commit 94f7b2b into PaddlePaddle:develop Jan 15, 2024
2 checks passed
@luotao1
Copy link
Collaborator

luotao1 commented Jan 15, 2024

@cocoshe 请cherry-pick到release/2.6分支

@tianshuo78520a
Copy link
Collaborator

如果使用docker run GPU 镜像,需要添加--gpups all这个参数,我看PR中没有写,这样启动会找不到gpu。 @cocoshe

@cocoshe
Copy link
Contributor Author

cocoshe commented Feb 5, 2024

如果使用docker run GPU 镜像,需要添加--gpups all这个参数,我看PR中没有写,这样启动会找不到gpu。 @cocoshe

我记得安装NVIDIA Container Toolkit的时候会让你配置一下docker daemon:
https://docs.nvidia.com/datacenter/cloud-native/container-toolkit/1.14.4/install-guide.html#configuring-docker

/etc/docker/daemon.json

{
    "runtimes": {
        "nvidia": {
            "args": [],
            "path": "nvidia-container-runtime"
        }
    }
}

直接按照官方文档来应该可以给docker自动配置好gpu吧,不用每次run的时候加gpu相关参数了

@tianshuo78520a
Copy link
Collaborator

一样需要添加,我本地也是这样配置的,但如果在docker run时候不加--gpus all 依然会报找不到gpu,你本地是可以的么?

image

@cocoshe
Copy link
Contributor Author

cocoshe commented Feb 5, 2024

一样需要添加,我本地也是这样配置的,但如果在docker run时候不加--gpus all 依然会报找不到gpu,你本地是可以的么?

image

sry刚刚试了一下,确实是要加一下--gpus all,我在文档中补充一下,谢谢指出!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants