Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docathon][Add API Legend No.9]add flatten lenged #6770

Merged
merged 8 commits into from
Aug 22, 2024

Conversation

Lans1ot
Copy link
Contributor

@Lans1ot Lans1ot commented Jul 19, 2024

尝试为 flatten 增加图例

Copy link

paddle-bot bot commented Jul 19, 2024

感谢你贡献飞桨文档,文档预览构建中,Docs-New 跑完后即可预览,预览链接:http://preview-pr-6770.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html
预览工具的更多说明,请参考:飞桨文档预览工具

Copy link
Collaborator

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 我觉得可以展示从 3d -> 2d Tensor 的 flatten 过程(也要说清楚 start_axis 和 stop_axis)
  • 图片属性可以加一个 :width: 500。不设置的话有些太大了

@luotao1 luotao1 added HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务 and removed HappyOpenSource 快乐开源活动issue与PR labels Jul 22, 2024
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

很棒~有几点需要优化一下

  • 轴的名称用 axis = 0 axis = 1 等来说明,用 x y 会比较模糊
  • 右边 flatten 后的三张图片感觉放一列有点挤?可以看看放一行效果怎样
  • 可以举个shape 为 [2,2,2] 的例子,因为 [3,3,3] 好像图片会比较大
  • 最好 flatten 后展示的也是正方形方块,这儿因为轴比例变了导致变成长方形


.. image:: ../../images/api_legend/flatten.png
:alt: 图例
:width: 500
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:width: 500
:width: 700

好像调的太小了...调大一点

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

图片压缩一下,到 200 kb以内

@Lans1ot
Copy link
Contributor Author

Lans1ot commented Aug 2, 2024

@sunzhongkai588 老师看看现在可以吗

@Lans1ot
Copy link
Contributor Author

Lans1ot commented Aug 7, 2024

@sunzhongkai588 请问现在还有哪里有问题需要修改qwq

@Lans1ot
Copy link
Contributor Author

Lans1ot commented Aug 14, 2024

@sunzhongkai588 请问现在可以吗

Copy link

@BiynXu BiynXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit fc3d29a into PaddlePaddle:develop Aug 22, 2024
2 checks passed
Aoraki-Dream pushed a commit to Aoraki-Dream/docs that referenced this pull request Sep 4, 2024
* add flatten lenged

* 按要求修改为三维情况

* 根据要求进行修改

* 调整图片大小和质量

* 格式化文本

* Update docs/api/paddle/flatten_cn.rst

* 重新绘制图片

* 重新绘制图片

---------

Co-authored-by: zachary sun <70642955+sunzhongkai588@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants