-
Notifications
You must be signed in to change notification settings - Fork 724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【Hackathon 7th No.23】NO.23 为 Paddle 新增 ParameterDict API #6874
Conversation
感谢你贡献飞桨文档,文档预览构建中,Docs-New 跑完后即可预览,预览链接:http://preview-pr-6874.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html |
参数 | ||
:::::::::::: | ||
|
||
- **parameters** (ParameterDict|OrderedDict|list[(key, Tensor)],可选) - 可迭代的 Parameters。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 参数描述和英文保持一致吧。
- 英文参数名好像也写错了,写成 values 了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我把那个value改掉吧
PaddlePaddle/Paddle#68625
请review @sunzhongkai588
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PaddlePaddle/Paddle#68625
这个是修改英文参数的pr,请review,然后对应的docs也改掉了。
另外 PaddlePaddle/Paddle#68268 这个也跑完了的 @sunzhongkai588
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
代码风格检查没通过,CI没通过
|
||
| PyTorch | PaddlePaddle | 备注 | | ||
| ------- | ------------ | ----------------------------------- | | ||
| values | parameters | 可迭代的 Parameters,参数名不一致。 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个加一个仅字,仅参数名不一致
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的好的,已经修改了,请review
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.