Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docathon][Add API Legend No.55、22] add paddle.index_fill and paddle.shard_index doc image example -part #6939

Merged
merged 8 commits into from
Dec 10, 2024

Conversation

xu8117
Copy link
Contributor

@xu8117 xu8117 commented Nov 8, 2024

Copy link

paddle-bot bot commented Nov 8, 2024

感谢你贡献飞桨文档,文档预览构建中,Docs-New 跑完后即可预览,预览链接:http://preview-pr-6939.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html
预览工具的更多说明,请参考:飞桨文档预览工具

@xu8117 xu8117 changed the title [Docathon][Add API Legend No.55] add paddle.index_fill doc image example [Docathon][Add API Legend No.55、22] add paddle.index_fill and paddle.shard_index doc image example Nov 11, 2024
@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Nov 11, 2024
@PaddlePaddle PaddlePaddle unlocked this conversation Nov 11, 2024
Copy link
Collaborator

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

把 图解说明 都放在 参数 那栏的上方,即对 API 进行简单介绍的那部分

Copy link
Collaborator

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for docs

@luotao1
Copy link
Collaborator

luotao1 commented Nov 28, 2024

@tianhaodongbd 看下 shard_index

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

右上角的流程图用菱形表示判断,矩形表示处理,平行四边形表示输入/输出,是不是比较好
判断逻辑出来后两个处理语句统一为“v = ***” 或 “return ***",是不是好一点

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改流程图,麻烦抽空进行review

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bb19ef5411fa9922117c809d2a255385
我画了个草图,还请看下是不是可以修改的简洁点

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已经很简洁了,我直接替换文档中的图片可以吗

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我贴的是个草图,还请修改一个润色后的图,包括配色之类的

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shard_index流程图 drawio
这样合适吗

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.0 我担心画的不合适,只在回复里面贴了图,我想把图放进去,该怎么做

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你再提个PR,把原来的图换一下就行 @xu8117

Copy link

@tianhaodongbd tianhaodongbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for shard_index

@luotao1 luotao1 changed the title [Docathon][Add API Legend No.55、22] add paddle.index_fill and paddle.shard_index doc image example [Docathon][Add API Legend No.55、22] add paddle.index_fill and paddle.shard_index doc image example -part Dec 10, 2024
@luotao1 luotao1 merged commit 5a00e06 into PaddlePaddle:develop Dec 10, 2024
2 checks passed
@luotao1
Copy link
Collaborator

luotao1 commented Dec 10, 2024

请提交对应的英文文档

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants