update installation of libsndfile, add unitest of soundfile #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luotao1
requested review from
xinghai-sun and
pkuyym
and removed request for
xinghai-sun
luotao1
force-pushed
the
setup
branch
4 times, most recently
from
a38265e to
13e3cf8
Compare
pkuyym
requested changes
Jul 28, 2017
deep_speech_2/tests/test_setup.py
Outdated
| file = 'test.wav' | ||
| sf.write(file, data, 44100, format='WAV', subtype='FLOAT') | ||
| read, fs = sf.read(file) | ||
| assert np.all(read == data) |
There was a problem hiding this comment.
Please use self.assertEqual or self.assertTrue instead of assert
deep_speech_2/tests/test_setup.py
Outdated
| sf.write(file, data, 44100, format='WAV', subtype='FLOAT') | ||
| read, fs = sf.read(file) | ||
| assert np.all(read == data) | ||
| assert fs == 44100 |
There was a problem hiding this comment.
Please use self.assertEqual instead of assert
luotao1
changed the title
pkuyym
approved these changes
Jul 28, 2017
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ctypes.util.find_library()只在系统路径中查找libsndfile库。soundfile.read/write的单测。