Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make kenlm install more robust #182

Merged
merged 1 commit into from
Aug 1, 2017
Merged

make kenlm install more robust #182

merged 1 commit into from
Aug 1, 2017

Conversation

luotao1
Copy link
Contributor

@luotao1 luotao1 commented Aug 1, 2017 •
edited
Loading

由于安装kenlm时经常会出现两个bug，因此fork了一个kenlm的分支，在自己的分支中修正了这两个bug：
https://github.com/luotao1/kenlm/commit/455cf139973f11cba893187229e9b9b0844a47cc

  1. 移除-std=c++11
  2. util/mmap.cc中MAP_HUGETLB的问题

kuke
kuke approved these changes Aug 1, 2017
View reviewed changes
Copy link
Collaborator

@kuke kuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 3090971 into PaddlePaddle:develop Aug 1, 2017
@luotao1 luotao1 deleted the kenlm branch August 1, 2017 08:01
@xinghai-sun xinghai-sun mentioned this pull request Aug 1, 2017
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuke kuke kuke approved these changes

@xinghai-sun xinghai-sun Awaiting requested review from xinghai-sun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luotao1 @kuke