Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes wrong links to documents in Chinese #574

Merged
merged 3 commits into from
Jan 12, 2018

Conversation

kexinzhao
Copy link
Contributor

Fix #573
This English document should link to the English version of other documents.

This English document should link to the English version of other documents.
@kexinzhao kexinzhao requested review from lcy-seso and luotao1 January 12, 2018 03:54
README.md Outdated
@@ -34,7 +34,7 @@ In the example of click-through rate estimates, we first give the Google's Wide

Text classification is one of the most basic tasks in natural language processing. The deep learning method can eliminate the complex feature engineering, and use the original text as input to optimize the classification accuracy.

For text classification, we provide a non-sequential text classification model based on DNN and CNN. (For LSTM-based model, please refer to PaddleBook [Sentiment Analysis](https://github.com/PaddlePaddle/book/blob/develop/06.understand_sentiment/README.cn.md)).
For text classification, we provide a non-sequential text classification model based on DNN and CNN. (For LSTM-based model, please refer to PaddleBook [Sentiment Analysis](https://github.com/PaddlePaddle/book/blob/develop/06.understand_sentiment/README.md)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about change the link to http://www.paddlepaddle.org/docs/develop/book/06.understand_sentiment/index.html ?
where the format of latex formula is correctly shown.
(Maybe should change the README.cn.md correspondingly)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! Done for both README.md and README.cn.md.

Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@luotao1 luotao1 merged commit 788f701 into PaddlePaddle:develop Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants