Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid suppressing critical exception. #656

Merged
merged 1 commit into from
Feb 8, 2018
Merged

Avoid suppressing critical exception. #656

merged 1 commit into from
Feb 8, 2018

Conversation

pkuyym
Copy link
Contributor

@pkuyym pkuyym commented Feb 7, 2018

Fixes #651

@pkuyym pkuyym requested review from kuke and zhxfl February 7, 2018 12:42
kuke
kuke reviewed Feb 8, 2018
View reviewed changes
Copy link
Collaborator

@kuke kuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kuke
kuke approved these changes Feb 8, 2018 •
edited
Loading
View reviewed changes
@pkuyym pkuyym merged commit b62b05f into PaddlePaddle:develop Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuke kuke kuke approved these changes

@zhxfl zhxfl Awaiting requested review from zhxfl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pkuyym @kuke