Refine librispeech.py for DeepSpeech2. #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: 1. Add manifest line check. 2. Avoid re-unpacking if unpacked data already exists. 3. Add full_download (download all 7 sub-datasets of LibriSpeech).
xinghai-sun
requested review from
pkuyym,
qingqing01 and
kuke
and removed request for
pkuyym
pkuyym
reviewed
Jun 8, 2017
| @@ -18,6 +18,7 @@ For some machines, we also need to install libsndfile1. Details to be added. | |||
| ``` | |||
| cd data | |||
| python librispeech.py | |||
| cat manifest.libri.train-* > manifest.libri.train-all | |||
There was a problem hiding this comment.
Should we introduce the meaning of manifest.libri.train-* file ?
I see, the introduction details is in following section. Feel abrupt about manifest file.
deep_speech_2/data/librispeech.py
Outdated
| MD5_TRAIN_CLEAN_100 = "2a93770f6d5c6c964bc36631d331a522" | ||
| MD5_TRAIN_CLEAN_360 = "c0e676e450a7ff2f54aeade5171606fa" | ||
| MD5_TRAIN_OTHER_500 = "d1a0fd59409feb2c614ce4d30c387708" | ||
|
|
||
| NUM_LINES_TEST_CLEAN = 2620 |
There was a problem hiding this comment.
Please explain why it's necessary to check the line number when MD5 has been checked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #77
Summary: