The toggle visibility elements of the "Show/Hide columns" button on the PagerDutyPage do not work #123
Labels
bug
Something isn't working
Comments
10 tasks
t1agob
added a commit
that referenced
this issue
Jul 25, 2024
### Description This PR introduces a fix to the issue reported on #123 that prevents users from showing/hiding columns in the service mapping table on `PagerDutyPage`. **Issue number:** #123 ### Type of change - [ ] New feature (non-breaking change which adds functionality) - [x] Fix (non-breaking change which fixes an issue) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) ### Checklist - [x] I have performed a self-review of this change - [x] Changes have been tested - [ ] Changes are documented - [x] Changes generate *no new warnings* - [x] PR title follows [conventional commit semantics](https://www.conventionalcommits.org/en/v1.0.0/) If this is a breaking change 👇 - [ ] I have documented the migration process - [ ] I have implemented necessary warnings (if it can live side by side) ## Acknowledgement By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. **Disclaimer:** We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.
10 tasks
Merged
t1agob
added a commit
that referenced
this issue
Jul 25, 2024
### Description This release updates the `PagerDutyPage` component to add a new configurations tab where users can configure how they want to sync service dependencies between Backstage and PagerDuty. <img width="811" alt="image" src="https://github.com/user-attachments/assets/f8332378-2439-4b7d-b130-b73acccd666b"> **By default, service dependency syncing is disabled.** It's an opt-in feature and admins need to be aware of what it does because you might end up deleting existing service dependencies on Backstage or PagerDuty.‼️ Important: Due to a Backstage design decision it is not possible to fully overwrite the relations specified in each entity's configuration file. For that reason the option to synchronise strictly from PagerDuty side is not available. On this release we also introduced a fix that was preventing users from showing/hiding columns on the service to entity mapping table (#123). ## Acknowledgement By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. **Disclaimer:** We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.
|
Closing this issue as it's now fixed on version 0.15.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The toggle visibility elements of the "Show/Hide columns" button on the PagerDutyPage do not seem to work.
To Reproduce
Navigate to the PagerDutyPage component, wait for the Page to load, click on the
Show/Hide columnsbutton on the top right hand side of the table, try to toggle any element of the drop down menu or select theHide AllorShow all. Nothing works. It's impossible to toggle any element.Expected behavior
The chosen visibility toggle should change to off/on when selected. The
Hide AllandShow allbuttons should toggle off/on all visibility toggles. The change should result in hiding/showing the respective columns.Additional context
backstage version: 1.29.1
"@pagerduty/backstage-plugin": "0.14.1",
"@pagerduty/backstage-plugin-common": "0.2.0",
"@pagerduty/backstage-plugin-backend": "0.8.2"
The text was updated successfully, but these errors were encountered: