Optionally remove 'create incident' button from card #67
Labels
enhancement
New feature or request
good first issue
Indicates a good issue for first-time contributors
Comments
t1agob
changed the title
t1agob
added
the
good first issue
|
This requires a small change in the UI behaviour and therefore is tagged as |
|
This is now the default behaviour in the new PagerDutyCard UI released on version 0.10.0 of the frontend plugin. I will now proceed to close the issue. |
github-project-automation
bot
moved this from Under review
to Done
in PagerDuty plugin for Backstage
|
re-opening issue as it doesn't cover the scenario where |
10 tasks
t1agob
added a commit
that referenced
this issue
Apr 3, 2024
### Description This PR introduces a behaviour change when the `integration key` is missing from an entity configuration. Currently the behaviour is to disable the button but keep it on the screen. After discussing the plugin with several customers, many shared with us that they don't want people to manually create incidents from Backstage as incidents are automatically created from alerts. Therefore we decided to remove the button if the integration key is not provided as part of the entity configuration, like we already do when the `readonly` parameter is passed to the PagerDutyCard. This also allows us to save some valuable space in the PagerDutyCard. **Issue number:** #67 ### Type of change - [x] New feature (non-breaking change which adds functionality) - [ ] Fix (non-breaking change which fixes an issue) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) ### Checklist - [x] I have performed a self-review of this change - [x] Changes have been tested - [x] Changes are documented - [x] Changes generate *no new warnings* - [x] PR title follows [conventional commit semantics](https://www.conventionalcommits.org/en/v1.0.0/) If this is a breaking change 👇 - [ ] I have documented the migration process - [ ] I have implemented necessary warnings (if it can live side by side) ## Acknowledgement By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. **Disclaimer:** We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.
|
This feature has now been merged to This introduces a change in behaviour and hides the Create Incident button if the |
github-project-automation
bot
moved this from In Progress
to Done
in PagerDuty plugin for Backstage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Currently the PagerDuty Card shows the 'create incident' button even when configured with
service-idonly.According to the documentation if we only use the
service-idannotation on the service entity it will not be possible to create incidents and therefore the button becomes greyed-out.Describe the solution you'd like
To simplify the PagerDuty Card readability I would like the button to fully disappear when the card is configured as
read-onlyor whenservice-idis the only annotation provided on the service entity configuration.Additional context
This feature was requested by @asandoval and @jerroydmoore.
The text was updated successfully, but these errors were encountered: