Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: list only oncall users in plugin #38

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

t1agob
Copy link
Contributor

@t1agob t1agob commented Nov 15, 2023

Description

Current implementation lists all oncall users, on all escalation levels, for an escalation policy assigned to a specific service. This is how the PagerDuty API works currently.

Problems:

  • If an escalation policy contains an oncall schedule, then the user currently on-call is returned. But if individual users are used instead all of them are listed.
  • Same user might exist in different escalation levels which causes the same user to show up multiple times on the list.
  • The current implementation doesn't use the gravatar image used in PagerDuty. It uses a dummy avatar icon for everyone.

Proposed implementation:

  • List only users in escalation level 1 - these are the users that are actually oncall.
  • Remove duplicate users from the oncall user list
  • Add support for user profile picture and fallback to dummy avatar icon when an image is not provided.

Issue number: #36

Type of change

  • New feature (non-breaking change which adds functionality)
  • Fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented
  • Changes generate no new warnings
  • PR title follows conventional commit semantics

If this is a breaking change 👇

  • I have documented the migration process
  • I have implemented necessary warnings (if it can live side by side)

Acknowledgement

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

refactor oncall user list behavior to only show users on escalation level 1
@t1agob t1agob added bug Something isn't working enhancement New feature or request labels Nov 15, 2023
@t1agob t1agob self-assigned this Nov 15, 2023
@t1agob t1agob merged commit 2513204 into next Nov 15, 2023
3 checks passed
@t1agob t1agob deleted the 36-on-call-engineers-are-duplicated branch November 15, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

1 participant