Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: small sized PagerDutyCard component #95

Merged
merged 7 commits into from
Apr 30, 2024

Conversation

milenkotomic
Copy link
Contributor

@milenkotomic milenkotomic commented Apr 23, 2024

Description

Creates a new component PagerDutySmallCard. It shows the status of the service, service standards, the oncall engineer and insights. The two latests can be hide.

Issue number: #86

Type of change

  • New feature (non-breaking change which adds functionality)
  • Fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented
  • Changes generate no new warnings
  • PR title follows conventional commit semantics

If this is a breaking change 👇

  • I have documented the migration process
  • I have implemented necessary warnings (if it can live side by side)

Acknowledgement

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@milenkotomic milenkotomic requested a review from t1agob as a code owner April 23, 2024 18:33
@milenkotomic milenkotomic changed the base branch from main to next April 23, 2024 18:33
@t1agob
Copy link
Contributor

t1agob commented Apr 25, 2024

I'm currently analysing the new component and reviewing with a few PagerDuty folks and current plugin users. Will get back to you ASAP.

@t1agob t1agob linked an issue Apr 25, 2024 that may be closed by this pull request
@t1agob t1agob added the enhancement New feature or request label Apr 25, 2024
…agerDuty card

Signed-off-by: Tiago Barbosa <tbarbos@hotmail.com>
t1agob added 2 commits April 30, 2024 23:51
Signed-off-by: Tiago Barbosa <tbarbos@hotmail.com>
Signed-off-by: Tiago Barbosa <tbarbos@hotmail.com>
Copy link
Contributor

@t1agob t1agob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new card has been reviewed by multiple users and is approved.

@t1agob t1agob self-assigned this Apr 30, 2024
@t1agob t1agob merged commit 287ba71 into PagerDuty:next Apr 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small sized PagerDutyCard component
2 participants