r/pagerduty_escalation_policy: correctly set teams

[gordonbondon]

While working on #126 I've discovered this error:

make testacc TEST=./pagerduty TESTARGS='-run=TestAccPagerDutyEscalationPolicyWithTeams_Basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./pagerduty -v -run=TestAccPagerDutyEscalationPolicyWithTeams_Basic -timeout 120m
=== RUN   TestAccPagerDutyEscalationPolicyWithTeams_Basic
--- FAIL: TestAccPagerDutyEscalationPolicyWithTeams_Basic (19.53s)
    testing.go:629: Error destroying resource! WARNING: Dangling resources
        may exist. The full state and error is shown below.

        Error: errors during apply: DELETE API call to https://api.pagerduty.com/teams/P3NAB0C failed 400 Bad Request. Code: 6006, Errors: [Cannot delete team with existing associations; associations could be Escalation Policies, Services, Schedules or Subteams], Message: Team has existing associations

        State: pagerduty_team.foo:
          ID = P3NAB0C
          provider = provider.pagerduty
          description = foo
          name = tf-xog7u
FAIL
FAIL	github.com/terraform-providers/terraform-provider-pagerduty/pagerduty	19.562s
make: *** [testacc] Error 1

Teams attribute was not correctly set on read and underlying pagerduty sdk was not actually removing teams from policy. So terraform was trying to remove both resources in parallel.

This fix depends on fix in pagerduty go library heimweh/go-pagerduty#25

Acceptance tests after fix:

→ GOFLAGS=-mod=vendor make testacc TEST=./pagerduty TESTARGS='-run=TestAccPagerDutyEscalationPolicy'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./pagerduty -v -run=TestAccPagerDutyEscalationPolicy -timeout 120m
=== RUN   TestAccPagerDutyEscalationPolicy_import
--- PASS: TestAccPagerDutyEscalationPolicy_import (14.44s)
=== RUN   TestAccPagerDutyEscalationPolicy_Basic
--- PASS: TestAccPagerDutyEscalationPolicy_Basic (20.58s)
=== RUN   TestAccPagerDutyEscalationPolicyWithTeams_Basic
--- PASS: TestAccPagerDutyEscalationPolicyWithTeams_Basic (21.20s)
PASS
ok  	github.com/terraform-providers/terraform-provider-pagerduty/pagerduty	56.243s

[heimweh]

Hi @gordonbondon,

this looks good to me. Would you mind opening a PR with a vendor update as well?

Thank you so much! 🙏

[gordonbondon]

@heimweh here you go #130

[heimweh]

Thanks @gordonbondon 🙏 This LGTM 👍