Adding Event Rule Resource #150
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| package pagerduty | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "testing" | ||
|
|
||
| "github.com/hashicorp/terraform/helper/acctest" | ||
| "github.com/hashicorp/terraform/helper/resource" | ||
| ) | ||
|
|
||
| func TestAccPagerDutyEventRule_import(t *testing.T) { | ||
| eventRule := fmt.Sprintf("tf-%s", acctest.RandString(5)) | ||
|
|
||
| resource.Test(t, resource.TestCase{ | ||
| PreCheck: func() { testAccPreCheck(t) }, | ||
| Providers: testAccProviders, | ||
| CheckDestroy: testAccCheckPagerDutyEventRuleDestroy, | ||
| Steps: []resource.TestStep{ | ||
| { | ||
| Config: testAccCheckPagerDutyEventRuleConfig(eventRule), | ||
| }, | ||
|
|
||
| { | ||
| ResourceName: "pagerduty_event_rule.first", | ||
| ImportState: true, | ||
| ImportStateVerify: true, | ||
| }, | ||
| }, | ||
| }) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,145 @@ | ||
| package pagerduty | ||
|
|
||
| import ( | ||
| "encoding/json" | ||
| "log" | ||
|
|
||
| "github.com/hashicorp/terraform/helper/schema" | ||
| "github.com/heimweh/go-pagerduty/pagerduty" | ||
| ) | ||
|
|
||
| func resourcePagerDutyEventRule() *schema.Resource { | ||
| return &schema.Resource{ | ||
| Create: resourcePagerDutyEventRuleCreate, | ||
| Read: resourcePagerDutyEventRuleRead, | ||
| Update: resourcePagerDutyEventRuleUpdate, | ||
| Delete: resourcePagerDutyEventRuleDelete, | ||
| Importer: &schema.ResourceImporter{ | ||
| State: schema.ImportStatePassthrough, | ||
| }, | ||
| Schema: map[string]*schema.Schema{ | ||
| "action_json": { | ||
| Type: schema.TypeString, | ||
| Required: true, | ||
| }, | ||
| "condition_json": { | ||
| Type: schema.TypeString, | ||
| Required: true, | ||
| }, | ||
| "advanced_condition_json": { | ||
| Type: schema.TypeString, | ||
| Optional: true, | ||
| }, | ||
| "catch_all": { | ||
| Type: schema.TypeBool, | ||
| Optional: true, | ||
| }, | ||
| }, | ||
| } | ||
| } | ||
|
|
||
| func buildEventRuleStruct(d *schema.ResourceData) *pagerduty.EventRule { | ||
| eventRule := &pagerduty.EventRule{ | ||
| Actions: expandString(d.Get("action_json").(string)), | ||
| Condition: expandString(d.Get("condition_json").(string)), | ||
| } | ||
|
|
||
| if attr, ok := d.GetOk("advanced_condition_json"); ok { | ||
| eventRule.AdvancedCondition = expandString(attr.(string)) | ||
| } | ||
|
|
||
| if attr, ok := d.GetOk("catch_all"); ok { | ||
| eventRule.CatchAll = attr.(bool) | ||
| } | ||
|
|
||
| return eventRule | ||
| } | ||
|
|
||
| func expandString(v string) []interface{} { | ||
| var obj []interface{} | ||
| err := json.Unmarshal([]byte(v), &obj) | ||
|
|
||
| if err != nil { | ||
| log.Printf(string(err.Error())) | ||
| } | ||
|
|
||
| return obj | ||
| } | ||
|
|
||
| func flattenSlice(v []interface{}) string { | ||
| b, err := json.Marshal(v) | ||
| if err != nil { | ||
| log.Printf(string(err.Error())) | ||
|
There was a problem hiding this comment. Same as above, do we want to return the error here? |
||
| } | ||
| return string(b) | ||
| } | ||
|
|
||
| func resourcePagerDutyEventRuleCreate(d *schema.ResourceData, meta interface{}) error { | ||
| client := meta.(*pagerduty.Client) | ||
|
|
||
| eventRule := buildEventRuleStruct(d) | ||
|
|
||
| log.Printf("[INFO] Creating PagerDuty event rule: %s", "eventRule") | ||
|
|
||
| eventRule, _, err := client.EventRules.Create(eventRule) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| d.SetId(eventRule.ID) | ||
|
|
||
| return resourcePagerDutyEventRuleRead(d, meta) | ||
| } | ||
|
|
||
| func resourcePagerDutyEventRuleRead(d *schema.ResourceData, meta interface{}) error { | ||
| client := meta.(*pagerduty.Client) | ||
|
|
||
| log.Printf("[INFO] Reading PagerDuty event rule: %s", d.Id()) | ||
|
|
||
| resp, _, err := client.EventRules.List() | ||
| if err != nil { | ||
| return err | ||
| } | ||
| for _, rule := range resp.EventRules { | ||
|
There was a problem hiding this comment. What do you think about doing something like (not tested): var found *pagerduty.EventRule
for _, rule := range resp.EventRules {
if rule.ID == d.Id() {
found = rule
break
}
}
if found == nil {
d.SetId("")
}
...
d.Set("catch_all", rule.CatchAll)
...That way you can set the attributes outside the loop 🙂 There was a problem hiding this comment. This makes sense. I've adopted this idea in my next commit. |
||
| log.Printf("[DEBUG] Resp rule.ID: %s", rule.ID) | ||
| if rule.ID == d.Id() { | ||
| d.Set("action_json", flattenSlice(rule.Actions)) | ||
| d.Set("condition_json", flattenSlice(rule.Condition)) | ||
| d.Set("advanced_condition_json", flattenSlice(rule.AdvancedCondition)) | ||
| d.Set("catch_all", rule.CatchAll) | ||
| } | ||
| } | ||
| // check if eventRule not found | ||
| if _, ok := d.GetOk("action_json"); !ok { | ||
|
There was a problem hiding this comment. Does this work? This calls There was a problem hiding this comment. It appeared to have worked. 🤷♂ But, I've changed that logic to match what you were saying in the above comment. |
||
| return handleNotFoundError(err, d) | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
| func resourcePagerDutyEventRuleUpdate(d *schema.ResourceData, meta interface{}) error { | ||
| client := meta.(*pagerduty.Client) | ||
|
|
||
| eventRule := buildEventRuleStruct(d) | ||
|
|
||
| log.Printf("[INFO] Updating PagerDuty event rule: %s", d.Id()) | ||
|
|
||
| if _, _, err := client.EventRules.Update(d.Id(), eventRule); err != nil { | ||
| return err | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| func resourcePagerDutyEventRuleDelete(d *schema.ResourceData, meta interface{}) error { | ||
| client := meta.(*pagerduty.Client) | ||
|
|
||
| log.Printf("[INFO] Deleting PagerDuty event rule: %s", d.Id()) | ||
|
|
||
| if _, err := client.EventRules.Delete(d.Id()); err != nil { | ||
| return err | ||
| } | ||
|
|
||
| d.SetId("") | ||
|
|
||
| return nil | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,195 @@ | ||
| package pagerduty | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "log" | ||
| "strings" | ||
| "testing" | ||
|
|
||
| "github.com/hashicorp/terraform/helper/acctest" | ||
| "github.com/hashicorp/terraform/helper/resource" | ||
| "github.com/hashicorp/terraform/terraform" | ||
| "github.com/heimweh/go-pagerduty/pagerduty" | ||
| ) | ||
|
|
||
| func init() { | ||
| resource.AddTestSweepers("pagerduty_event_rule", &resource.Sweeper{ | ||
| Name: "pagerduty_event_rule", | ||
| F: testSweepEventRule, | ||
| Dependencies: []string{ | ||
| "pagerduty_service", | ||
| }, | ||
| }) | ||
| } | ||
|
|
||
| func testSweepEventRule(region string) error { | ||
| config, err := sharedConfigForRegion(region) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| client, err := config.Client() | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| resp, _, err := client.EventRules.List() | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| for _, rule := range resp.EventRules { | ||
| if strings.HasPrefix(rule.ID, "test") || strings.HasPrefix(rule.ID, "tf-") { | ||
| log.Printf("Destroying event rule %s", rule.ID) | ||
| if _, err := client.EventRules.Delete(rule.ID); err != nil { | ||
| return err | ||
| } | ||
| } | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| func TestAccPagerDutyEventRule_Basic(t *testing.T) { | ||
| eventRule := fmt.Sprintf("tf-%s", acctest.RandString(5)) | ||
| eventRuleUpdated := fmt.Sprintf("tf-%s", acctest.RandString(5)) | ||
|
|
||
| resource.Test(t, resource.TestCase{ | ||
| PreCheck: func() { testAccPreCheck(t) }, | ||
| Providers: testAccProviders, | ||
| CheckDestroy: testAccCheckPagerDutyEventRuleDestroy, | ||
| Steps: []resource.TestStep{ | ||
| { | ||
| Config: testAccCheckPagerDutyEventRuleConfig(eventRule), | ||
| Check: resource.ComposeTestCheckFunc( | ||
| testAccCheckPagerDutyEventRuleExists("pagerduty_event_rule.first"), | ||
| ), | ||
| }, | ||
|
|
||
| { | ||
| Config: testAccCheckPagerDutyEventRuleConfigUpdated(eventRuleUpdated), | ||
| Check: resource.ComposeTestCheckFunc( | ||
| testAccCheckPagerDutyEventRuleExists("pagerduty_event_rule.foo_resource_updated"), | ||
| ), | ||
| }, | ||
| }, | ||
| }) | ||
| } | ||
|
|
||
| func testAccCheckPagerDutyEventRuleDestroy(s *terraform.State) error { | ||
| client := testAccProvider.Meta().(*pagerduty.Client) | ||
| for _, r := range s.RootModule().Resources { | ||
| if r.Type != "pagerduty_event_rule" { | ||
| continue | ||
| } | ||
| // get list of event_rules and then check that list. | ||
| resp, _, err := client.EventRules.List() | ||
| if err != nil { | ||
| return err | ||
| } | ||
| for _, er := range resp.EventRules { | ||
| if er.ID == r.Primary.ID { | ||
| return fmt.Errorf("Event Rule still exists") | ||
| } | ||
| } | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| func testAccCheckPagerDutyEventRuleExists(n string) resource.TestCheckFunc { | ||
| return func(s *terraform.State) error { | ||
| rs, ok := s.RootModule().Resources[n] | ||
| if !ok { | ||
| return fmt.Errorf("Not found: %s", n) | ||
| } | ||
| if rs.Primary.ID == "" { | ||
| return fmt.Errorf("No Escalation Policy ID is set") | ||
| } | ||
|
|
||
| client := testAccProvider.Meta().(*pagerduty.Client) | ||
| resp, _, err := client.EventRules.List() | ||
| if err != nil { | ||
| return err | ||
| } | ||
| var found *pagerduty.EventRule | ||
|
|
||
| for _, rule := range resp.EventRules { | ||
| if rule.ID == rs.Primary.ID { | ||
| found = rule | ||
| } | ||
| } | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| if found.ID != rs.Primary.ID { | ||
| return fmt.Errorf("Escalation policy not found: %v - %v", rs.Primary.ID, found) | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
| } | ||
|
|
||
| func testAccCheckPagerDutyEventRuleConfig(eventRule string) string { | ||
| return fmt.Sprintf(` | ||
| variable "action_list" { | ||
| default = [["route","P5DTL0K"],["severity","warning"],["annotate","%s"],["priority","PL451DT"]] | ||
| } | ||
| variable "condition_list" { | ||
| default = ["and",["contains",["path","payload","source"],"website"]] | ||
| } | ||
| variable "advanced_condition_list" { | ||
| default = [ | ||
| [ | ||
| "scheduled-weekly", | ||
| 1565392127032, | ||
| 3600000, | ||
| "America/Los_Angeles", | ||
| [ | ||
| 1, | ||
| 3, | ||
| 5, | ||
| 7 | ||
| ] | ||
| ] | ||
| ] | ||
| } | ||
| resource "pagerduty_event_rule" "first" { | ||
| action_json = jsonencode(var.action_list) | ||
| condition_json = jsonencode(var.condition_list) | ||
| advanced_condition_json = jsonencode(var.advanced_condition_list) | ||
| } | ||
| `, eventRule) | ||
| } | ||
|
|
||
| func testAccCheckPagerDutyEventRuleConfigUpdated(eventRule string) string { | ||
| return fmt.Sprintf(` | ||
| variable "action_list" { | ||
| default = [["route","P5DTL0K"],["severity","warning"],["annotate","%s"],["priority","PL451DT"]] | ||
| } | ||
| variable "condition_list" { | ||
| default = ["and",["contains",["path","payload","source"],"website"],["contains",["path","headers","from","0","address"],"homer"]] | ||
| } | ||
| variable "advanced_condition_list" { | ||
| default = [ | ||
| [ | ||
| "scheduled-weekly", | ||
| 1565392127032, | ||
| 3600000, | ||
| "America/Los_Angeles", | ||
| [ | ||
| 1, | ||
| 3, | ||
| 5, | ||
| 7 | ||
| ] | ||
| ] | ||
| ] | ||
| } | ||
| resource "pagerduty_event_rule" "foo_resource_updated" { | ||
| action_json = jsonencode(var.action_list) | ||
| condition_json = jsonencode(var.condition_list) | ||
| advanced_condition_json = jsonencode(var.advanced_condition_list) | ||
| } | ||
| `, eventRule) | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about returning the error here if JSON unmarshal fails?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency, I've adopted the same strategy used in the extension resource. Would that work?