-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for managing maintenance windows #17
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heimweh
changed the title
[WIP] Add support for managing maintenance windows
Add support for managing maintenance windows
Jul 7, 2017
Tests are passing: ==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./pagerduty -v -timeout 120m
=== RUN TestConfigEmptyToken
--- PASS: TestConfigEmptyToken (0.00s)
=== RUN TestConfigSkipCredsValidation
--- PASS: TestConfigSkipCredsValidation (0.00s)
=== RUN TestAccDataSourcePagerDutyEscalationPolicy_Basic
=== RUN TestAccDataSourcePagerDutySchedule_Basic
=== RUN TestAccDataSourcePagerDutyUser_Basic
=== RUN TestAccDataSourcePagerDutyVendor_Basic
=== RUN TestAccPagerDutyEscalationPolicy_import
=== RUN TestAccPagerDutyMaintenanceWindow_import
=== RUN TestAccPagerDutySchedule_import
=== RUN TestAccPagerDutyServiceIntegration_import
=== RUN TestAccPagerDutyService_import
=== RUN TestAccPagerDutyServiceWithIncidentUrgency_import
=== RUN TestAccPagerDutyTeamMembership_import
=== RUN TestAccPagerDutyTeam_import
=== RUN TestAccPagerDutyUser_import
=== RUN TestProvider
--- PASS: TestProvider (0.00s)
=== RUN TestProviderImpl
--- PASS: TestProviderImpl (0.00s)
=== RUN TestAccPagerDutyAddon_Basic
=== RUN TestAccPagerDutyEscalationPolicy_Basic
=== RUN TestAccPagerDutyEscalationPolicyWithTeams_Basic
=== RUN TestAccPagerDutyMaintenanceWindow_Basic
=== RUN TestAccPagerDutySchedule_Basic
=== RUN TestAccPagerDutySchedule_BasicWeek
=== RUN TestAccPagerDutySchedule_Multi
=== RUN TestAccPagerDutyServiceIntegration_Basic
=== RUN TestAccPagerDutyServiceIntegrationGeneric_Basic
=== RUN TestAccPagerDutyService_Basic
=== RUN TestAccPagerDutyService_BasicWithIncidentUrgencyRules
=== RUN TestAccPagerDutyService_FromBasicToCustomIncidentUrgencyRules
=== RUN TestAccPagerDutyTeamMembership_Basic
=== RUN TestAccPagerDutyTeam_Basic
=== RUN TestAccPagerDutyUser_Basic
=== RUN TestAccPagerDutyUserWithTeams_Basic
--- PASS: TestAccPagerDutyEscalationPolicy_import (31.11s)
--- PASS: TestAccPagerDutyService_import (32.00s)
--- PASS: TestAccDataSourcePagerDutyEscalationPolicy_Basic (32.57s)
--- PASS: TestAccPagerDutyEscalationPolicyWithTeams_Basic (37.89s)
--- PASS: TestAccPagerDutySchedule_import (12.78s)
--- PASS: TestAccPagerDutyServiceIntegration_import (17.42s)
--- PASS: TestAccPagerDutyMaintenanceWindow_import (16.04s)
--- PASS: TestAccPagerDutyService_BasicWithIncidentUrgencyRules (16.78s)
--- PASS: TestAccPagerDutyTeam_Basic (10.13s)
--- PASS: TestAccPagerDutyUser_Basic (13.84s)
--- PASS: TestAccPagerDutyTeamMembership_Basic (10.10s)
--- PASS: TestAccPagerDutyUserWithTeams_Basic (26.50s)
--- PASS: TestAccPagerDutySchedule_Multi (14.86s)
--- PASS: TestAccPagerDutyService_FromBasicToCustomIncidentUrgencyRules (22.35s)
--- PASS: TestAccPagerDutyService_Basic (20.42s)
--- PASS: TestAccDataSourcePagerDutyVendor_Basic (4.35s)
--- PASS: TestAccDataSourcePagerDutyUser_Basic (11.66s)
--- PASS: TestAccPagerDutyServiceIntegrationGeneric_Basic (26.83s)
--- PASS: TestAccPagerDutyServiceIntegration_Basic (26.39s)
--- PASS: TestAccDataSourcePagerDutySchedule_Basic (14.99s)
--- PASS: TestAccPagerDutySchedule_Basic (14.93s)
--- PASS: TestAccPagerDutyUser_import (11.24s)
--- PASS: TestAccPagerDutySchedule_BasicWeek (19.31s)
--- PASS: TestAccPagerDutyEscalationPolicy_Basic (16.40s)
--- PASS: TestAccPagerDutyAddon_Basic (11.51s)
--- PASS: TestAccPagerDutyTeamMembership_import (12.14s)
--- PASS: TestAccPagerDutyMaintenanceWindow_Basic (26.42s)
--- PASS: TestAccPagerDutyTeam_import (7.64s)
--- PASS: TestAccPagerDutyServiceWithIncidentUrgency_import (16.69s)
PASS
ok github.com/terraform-providers/terraform-provider-pagerduty/pagerduty 143.984s |
grubernaut
approved these changes
Jul 10, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for managing maintenance windows in PagerDuty.
A maintenance window is used to temporarily disable one or more services for a set period of time.
Maintenance windows are specified to start at a certain time and end after they have begun. Once started, a maintenance window cannot be deleted; it can only be ended immediately to re-enable the service.