Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/pagerduty/data_source_pagerduty_vendor: Fix ExactMatch test #178

Merged
merged 1 commit into from
Jan 31, 2020

Conversation

heimweh
Copy link
Collaborator

@heimweh heimweh commented Jan 31, 2020

PKG4M95 is the legacy vendor id.
This changes the test to use the non-legacy vendor id for Slack.

Fixes the following test failure:

------- Stdout: -------
=== RUN   TestAccDataSourcePagerDutyVendor_ExactMatch
--- FAIL: TestAccDataSourcePagerDutyVendor_ExactMatch (2.18s)
    testing.go:569: Step 0 error: Check failed: Check 1/2 error: data.pagerduty_vendor.foo: Attribute 'id' expected "PKG4M95", got "PKAPG94"

PKG4M95 is the legacy vendor ID,
so this changes the test to use the non-legacy vendor ID for Slack.
@ghost ghost added the size/XS label Jan 31, 2020
@heimweh
Copy link
Collaborator Author

heimweh commented Jan 31, 2020

Tests are passing:

[TestAccDataSourcePagerDutyVendor_ExactMatch] [Test Output]
=== RUN   TestAccDataSourcePagerDutyVendor_ExactMatch
--- PASS: TestAccDataSourcePagerDutyVendor_ExactMatch (3.04s)
PASS

Copy link
Contributor

@stmcallister stmcallister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stmcallister stmcallister merged commit e5c56e2 into PagerDuty:master Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants