Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Bug in Service Resource Where alert_grouping_timeout wasn't saving 0 values #190

Merged
merged 16 commits into from
Mar 18, 2020
Merged

Fixing Bug in Service Resource Where alert_grouping_timeout wasn't saving 0 values #190

merged 16 commits into from
Mar 18, 2020

Conversation

stmcallister
Copy link
Contributor

"Customer is trying to add the alert_grouping_timeout argument with a value of 0 so that their service's alert grouping continues until the PD incident is resolved. When they add this parameter, it is not reflected in the API request made to us. "

I changed GetOk to GetOkExists to allow for values of 0. Test results here:

TF_ACC=1 go test -run "TestAccPagerDutyService_Basic" ./pagerduty -v -timeout 120m
=== RUN   TestAccPagerDutyService_Basic
--- PASS: TestAccPagerDutyService_Basic (13.76s)
=== RUN   TestAccPagerDutyService_BasicWithIncidentUrgencyRules
--- PASS: TestAccPagerDutyService_BasicWithIncidentUrgencyRules (13.94s)
PASS
ok  	github.com/terraform-providers/terraform-provider-pagerduty/pagerduty	28.738s

Scott McAllister added 16 commits October 10, 2019 14:10
making advanced_condition optional in docs
b6f8795
Merge remote-tracking branch 'upstream/master'
e11a592
Merge remote-tracking branch 'upstream/master'
2e228b6
fixing catch_all event_rule issue PagerDuty#167
2504c4a
fixing alert_grouping bug when reading service resource
82a0530
Merge remote-tracking branch 'upstream/master'
f242515
updating changelog
8d193f5
Merge remote-tracking branch 'upstream/master'
0cf4cd8
Merge remote-tracking branch 'upstream/master'
26eaf12
adding ruleset and ruleset_rule resources
9595417
Merge remote-tracking branch 'upstream/master'
01a73f7
adding routing_keys and docs
8a6e239
Merge remote-tracking branch 'upstream/master'
add8d19
rolling back rulesets until API is ready
2248d00
Merge remote-tracking branch 'upstream/master'
5e85314
fixing bug with service.alert_grouping_timeout zero
7897b59
heimweh
heimweh approved these changes Mar 18, 2020
View reviewed changes
Copy link
Collaborator

@heimweh heimweh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This LGTM 👍

@stmcallister stmcallister merged commit 974b486 into PagerDuty:master Mar 18, 2020
stmcallister pushed a commit that referenced this pull request Mar 19, 2020
Updating CHANGELONG.md
f22d425 
adding PRs #188 and #190.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heimweh heimweh heimweh approved these changes

Assignees
No one assigned
Labels
documentation size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stmcallister @heimweh @bartoszspiechowicz