Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement retry logic in all read requests #208

Merged
merged 6 commits into from
Jun 10, 2020

Conversation

mLupine
Copy link
Contributor

@mLupine mLupine commented Apr 16, 2020

Although the changes I made in #191 fixed the problem described in my previous PR, we started encountering the same problems in read requests other than service and service integrations.

This PR implements the same retry logic to all data sources and resources. As previously, the changes are already field-tested in our organization 👍

@ghost ghost added the size/XL label Apr 16, 2020
@stmcallister
Copy link
Contributor

Thanks for submitting this! It's a much needed feature. Would you mind also adding a sleep on each retry? That way we give the API a break. Even just one second would be fine.

@mLupine
Copy link
Contributor Author

mLupine commented May 27, 2020

Hey @stmcallister! Added a delay before returning any retryable error, that should do the trick :)

@stmcallister stmcallister merged commit cf092da into PagerDuty:master Jun 10, 2020
@stmcallister
Copy link
Contributor

Well done! Thank you for doing that. i reduced each delay down to 2 seconds, and added the same retry logic to creating Event Rules so that their tests will finally pass. :) Appreciate the work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants