Fix issue with disabling a ruleset #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 18, 2020 13:27
divbhasin
force-pushed
the
250-change-disabled-behaviour
branch
from
5479aa4 to
a8060d4
Compare
stmcallister
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #250.
There are 2 main changes here:
I added to the 2 existing ruleset_rule tests. Now, we first create a ruleset rule that has disabled=true, and then we update the same ruleset rule to disabled=false. This helps verify that we can go from true -> false, which was an issue before according to pagerduty_ruleset_rule - cannot set disabled=true once disabled=false was set #250. We still get the verification of creating and updating ruleset rules that we had before.
There was a change I made to the go-pagerduty client to enable this to work here. Thus, I needed to vendor the go-pagerduty repo, which also grabbed some other updates to the client.