Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Bug in Event Rule Positioning #301

Merged
merged 1 commit into from
Feb 10, 2021

Conversation

stmcallister
Copy link
Contributor

@stmcallister stmcallister commented Feb 10, 2021

Changes in the last provider release caused Event Rule positioning (both in Service Event Rules and Ruleset Rules) to have issues setting position 0, as well as ignoring when positions weren't set. This fix should change that. #300

RulesetRule Test Results

TF_ACC=1 go test -run "TestAccPagerDutyRulesetRule" ./pagerduty -v -timeout 120m
=== RUN   TestAccPagerDutyRulesetRule_import
--- PASS: TestAccPagerDutyRulesetRule_import (4.86s)
=== RUN   TestAccPagerDutyRulesetRule_Basic
--- PASS: TestAccPagerDutyRulesetRule_Basic (6.06s)
=== RUN   TestAccPagerDutyRulesetRule_MultipleRules
--- PASS: TestAccPagerDutyRulesetRule_MultipleRules (6.12s)
PASS
ok  	github.com/terraform-providers/terraform-provider-pagerduty/pagerduty	18.277s

ServiceEventRule Test Rules

TF_ACC=1 go test -run "TestAccPagerDutyServiceEventRule" ./pagerduty -v -timeout 120m        
=== RUN   TestAccPagerDutyServiceEventRule_import
--- PASS: TestAccPagerDutyServiceEventRule_import (11.76s)
=== RUN   TestAccPagerDutyServiceEventRule_Basic
--- PASS: TestAccPagerDutyServiceEventRule_Basic (12.94s)
=== RUN   TestAccPagerDutyServiceEventRule_MultipleRules
--- PASS: TestAccPagerDutyServiceEventRule_MultipleRules (12.96s)
PASS
ok  	github.com/terraform-providers/terraform-provider-pagerduty/pagerduty	38.307s

@stmcallister stmcallister requested a review from heimweh February 10, 2021 22:05
@stmcallister stmcallister merged commit 0c770f5 into PagerDuty:master Feb 10, 2021
@stmcallister stmcallister deleted the rule-position-zero branch February 10, 2021 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants