Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restoring Needed omitempty o RuleAction.Suppress Fields #302

Merged

Conversation

stmcallister
Copy link
Contributor

Recent change to the RuleAction.Suppress object made it impossible to simply set the value field. This change will allow for that and also includes the suppress field in tests. This change affects both Ruleset Rules and Service Event Rules.

Ruleset Rule Test Results

TF_ACC=1 go test -run "TestAccPagerDutyRulesetRule" ./pagerduty -v -timeout 120m     
=== RUN   TestAccPagerDutyRulesetRule_import
--- PASS: TestAccPagerDutyRulesetRule_import (5.33s)
=== RUN   TestAccPagerDutyRulesetRule_Basic
--- PASS: TestAccPagerDutyRulesetRule_Basic (6.60s)
=== RUN   TestAccPagerDutyRulesetRule_MultipleRules
--- PASS: TestAccPagerDutyRulesetRule_MultipleRules (6.83s)
PASS
ok  	github.com/terraform-providers/terraform-provider-pagerduty/pagerduty	24.884s

Service Event Rule Test Results

TF_ACC=1 go test -run "TestAccPagerDutyServiceEventRule" ./pagerduty -v -timeout 120m
=== RUN   TestAccPagerDutyServiceEventRule_import
--- PASS: TestAccPagerDutyServiceEventRule_import (10.65s)
=== RUN   TestAccPagerDutyServiceEventRule_Basic
--- PASS: TestAccPagerDutyServiceEventRule_Basic (11.74s)
=== RUN   TestAccPagerDutyServiceEventRule_MultipleRules
--- PASS: TestAccPagerDutyServiceEventRule_MultipleRules (12.39s)
PASS
ok  	github.com/terraform-providers/terraform-provider-pagerduty/pagerduty	35.365s

@stmcallister stmcallister requested a review from dobs February 11, 2021 23:51
@stmcallister stmcallister merged commit 8467d9b into PagerDuty:master Feb 12, 2021
@stmcallister stmcallister deleted the fix-rule-action-suppress branch February 12, 2021 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants