Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response Play Responder to Optional and User Email to Case Insensitive #316

Merged
merged 4 commits into from
Mar 26, 2021

Conversation

stmcallister
Copy link
Contributor

The responder field on the pagerduty_response_play resource is, in fact, not required on the PagerDuty API. Correcting the resource schema to match that fact. Response Play test results.

TF_ACC=1 go test -run "TestAccPagerDutyResponsePlay" ./pagerduty -v -timeout 120m
=== RUN   TestAccPagerDutyResponsePlay_import
--- PASS: TestAccPagerDutyResponsePlay_import (7.50s)
=== RUN   TestAccPagerDutyResponsePlay_Basic
--- PASS: TestAccPagerDutyResponsePlay_Basic (9.21s)
PASS
ok  	github.com/terraform-providers/terraform-provider-pagerduty/pagerduty	17.387s

Also set the email field to suppress diff when there is a difference in case, since emails are case insensative.

TF_ACC=1 go test -run "TestAccPagerDutyUser_Basic" ./pagerduty -v -timeout 120m
=== RUN   TestAccPagerDutyUser_Basic
--- PASS: TestAccPagerDutyUser_Basic (7.43s)
PASS
ok  	github.com/terraform-providers/terraform-provider-pagerduty/pagerduty	8.063s

@stmcallister stmcallister requested a review from dobs March 23, 2021 20:31
@stmcallister stmcallister merged commit 5318a15 into PagerDuty:master Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants