Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor edits to service resource's scheduled_actions block #360

Merged

Conversation

katkasian
Copy link
Contributor

Adds minor edits to service resource documentation, mainly focusing on scheduled_actions block.

@chai-srini
Copy link

@katkasian Are you able to provision a Service with "use_support_hours" in incident_urgency_rule and not specify any scheduled_actions?

@stmcallister
Copy link
Contributor

Hi @katkasian! I checked with the PagerDuty engineering team and they verified that, "scheduled_actions is required when the incident_urgency_rule is use_support_hours, and forbidden otherwise."

@@ -87,7 +87,7 @@ The block contains the following arguments:
* `start_time` - The support hours' starting time of day.
* `end_time` - The support hours' ending time of day.

When using `type = "use_support_hours"` in `incident_urgency_rule` you must specify at least one (otherwise optional) `scheduled_actions` block.
When using `type = "use_support_hours"` in `incident_urgency_rule` you can specify an optional `scheduled_actions` block.
Copy link
Contributor

@stmcallister stmcallister Aug 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the information I received from PagerDuty Engineering, the new language should be something more like,

A scheduled_actions block is required when using type = "use_support_hours" in incident_urgency_rule.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @stmcallister ! Reflected your comment.

Copy link
Contributor

@stmcallister stmcallister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you!

@stmcallister stmcallister merged commit 0490db7 into PagerDuty:master Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants