Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regex validation to start_time_of_day #383

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

drastawi
Copy link
Contributor

@drastawi drastawi commented Sep 9, 2021

Add validation for the start time format. It will prevent perma-diff issues with times like "9:00:00" rather than the PD-desired "09:00:00"

@drastawi
Copy link
Contributor Author

drastawi commented Sep 9, 2021

@stmcallister

Copy link
Contributor

@stmcallister stmcallister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🎉 Thank you for adding this!

@stmcallister stmcallister merged commit 784c444 into PagerDuty:master Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants