[ORCA-3486] Extend unrouted tests, add CustomizeDiff, clean shared functions #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexzakabluk
commented
May 23, 2022
| "pagerduty_event_orchestration_unrouted.unrouted", "sets.0.rules.0.actions.0.variables.1.type", "regex"), | ||
| resource.TestCheckResourceAttr( | ||
| "pagerduty_event_orchestration_unrouted.unrouted", "sets.0.rules.0.actions.0.variables.1.value", "High memory usage on (.*) server"), | ||
| resource.TestCheckTypeSetElemNestedAttrs( |
There was a problem hiding this comment.
Refactored this section and switched to TestCheckTypeSetElemNestedAttrs instead of TestCheckResourceAttr which improves the code readability a bit for the key value objects.
alexzakabluk
commented
May 23, 2022
| ), | ||
| }, | ||
| // Providing invalid extractions attributes for set rules |
There was a problem hiding this comment.
Added tests for corrupted extractions (pattern we used in the service path)
alexzakabluk
changed the title
alenapan
approved these changes
May 24, 2022
alenapan
pushed a commit
that referenced
this pull request
May 27, 2022
…nctions (#510) * Extend unrouted tests, add CustomizeDiff, clean shared functions * Move shared functions for unrouted and service paths to utils file
alenapan
added a commit
that referenced
this pull request
Jun 1, 2022
* ORCA-3459 - event orchestration resource * reformat * [REVERT LATER] Temporarily pointing to the local copy of go-pagerduty * rename Orchestration references to EventOrchestration * add more properties, mapping logic; add tests * more tests to event_orchestration_resource * add datasource event orchestration * [REVERT LATER]-local testing * fix create logic (set integrations), remove description and routes from orchestration data source * fix data source, add data source tests * reformat * Add import tests * update to latest alenapan/go-pagerduty * add team checks to the tests * [ORCA-3475] Allow deleting event orchestration team from an orchestration (#494) * support unsetting orch team * add retry logic to the event orchestration update method * [ORCA-3463] Orchestration Path Router Resource (#493) * router path * Add support for parent * refactor * update handler and actions support * support conditions * move conditions to util * move parent to util * test for multiple rules and conditions * actions and catchall * refactor tests * validateFunc * refactor * undo local vendor module path change * rules schema change and test * PR comments addressed * Event orchestration unrouted resource (#495) * Init commit for unrouted * Added tests for unrouted * Added catch_all to unrouted schema * Tweaked catch_all * Merge event-orchestrations * Add testacc for unrouted * Added full config test for unrouted * Add test for number of extractions and variables * Cleaned router and added new test checks to unrouted * Change escalation_policy from snake case to camel case * make type computed and set it on read/update * Orca 3486 refactor (#500) * Clean sweeper function for router/unrouted * Clean sweeper function * [ORCA-3465] - Event Orchestration Service path resource (#499) * ORCA-3465 - Event Orchestration Service Path resource * add resource file * fix read/update, add test * more tests * more service path tests, add conditions * more tests * more tests * add more service path props * fix orch path PUT payload, add tests * fix Suspend * ToDos * add catch_all support, fix tests * add support for regex extractions, add mor tests, add service path import test * update client * PR feedback * Flatten teams block (#506) * Flatten teams block * Fixed naming for the test orchestration * ORCA-3486 - remove team attribute from service path * flatten/rename parent to 'service' for service path * remove type attribute from unrouted * remove type attribute from router * flatten/rename parent to 'event_orchestration' for router * set event_orchestration attr on router import * flatten/rename parent to 'event_orchestration' for unrouted * Clean teams block * revert changes on web file * [ORCA-3486] - Reuse shared Event Orchestration Path logic, add import tests (#509) * ORCA-3486 - add import tests for router/unrouted * ORCA-3486 - add import tests for router, unrouted * reuse severity/event_action validation functions in unrouted/service * reuse variables and extractions schema in router/unrouted * reuse shared conditions schema and mapping functions in router/unrouted/service * [ORCA-3486] Extend unrouted tests, add CustomizeDiff, clean shared functions (#510) * Extend unrouted tests, add CustomizeDiff, clean shared functions * Move shared functions for unrouted and service paths to utils file * orchestration and path resource documentation * datasource documentation * refactor * update comment * update type field documentation * update documentation * cleanup * Remove mention of the suppress action from event_orchestration_unrouted docs * Add "Optional" info to 1 attribute in event_orchestration_service docs * give a better datasource example * cleanup * Add Event Orchestration info to the CHANGELOG (release date TBD) (#514) * update go-pagerduty package * Router - make sets, rules, conditions singular * Unrouted, Service - make sets, rules, conditions, variables, extractions, pd_automation_actions, automations_action (headers, params) singular * Event Orchestration - make integrations singular * update Event Orchestration documentation * EO data source - retry on any error * EO data source - retry on any error Co-authored-by: Pari Dhanakoti <pdhanakoti@pagerduty.com> Co-authored-by: Alex Zakabluk <azakabluk@pagerduty.com> Co-authored-by: Marcos Wright-Kuhns <webmaster@wrightkuhns.com> Co-authored-by: Scott McAllister <smcallister@pagerduty.com>
stmcallister
pushed a commit
that referenced
this pull request
Jun 9, 2022
* ORCA-3459 - event orchestration resource * reformat * [REVERT LATER] Temporarily pointing to the local copy of go-pagerduty * rename Orchestration references to EventOrchestration * add more properties, mapping logic; add tests * more tests to event_orchestration_resource * add datasource event orchestration * [REVERT LATER]-local testing * fix create logic (set integrations), remove description and routes from orchestration data source * fix data source, add data source tests * reformat * Add import tests * update to latest alenapan/go-pagerduty * add team checks to the tests * [ORCA-3475] Allow deleting event orchestration team from an orchestration (#494) * support unsetting orch team * add retry logic to the event orchestration update method * [ORCA-3463] Orchestration Path Router Resource (#493) * router path * Add support for parent * refactor * update handler and actions support * support conditions * move conditions to util * move parent to util * test for multiple rules and conditions * actions and catchall * refactor tests * validateFunc * refactor * undo local vendor module path change * rules schema change and test * PR comments addressed * Event orchestration unrouted resource (#495) * Init commit for unrouted * Added tests for unrouted * Added catch_all to unrouted schema * Tweaked catch_all * Merge event-orchestrations * Add testacc for unrouted * Added full config test for unrouted * Add test for number of extractions and variables * Cleaned router and added new test checks to unrouted * Change escalation_policy from snake case to camel case * make type computed and set it on read/update * Orca 3486 refactor (#500) * Clean sweeper function for router/unrouted * Clean sweeper function * [ORCA-3465] - Event Orchestration Service path resource (#499) * ORCA-3465 - Event Orchestration Service Path resource * add resource file * fix read/update, add test * more tests * more service path tests, add conditions * more tests * more tests * add more service path props * fix orch path PUT payload, add tests * fix Suspend * ToDos * add catch_all support, fix tests * add support for regex extractions, add mor tests, add service path import test * update client * PR feedback * Flatten teams block (#506) * Flatten teams block * Fixed naming for the test orchestration * ORCA-3486 - remove team attribute from service path * flatten/rename parent to 'service' for service path * remove type attribute from unrouted * remove type attribute from router * flatten/rename parent to 'event_orchestration' for router * set event_orchestration attr on router import * flatten/rename parent to 'event_orchestration' for unrouted * Clean teams block * revert changes on web file * [ORCA-3486] - Reuse shared Event Orchestration Path logic, add import tests (#509) * ORCA-3486 - add import tests for router/unrouted * ORCA-3486 - add import tests for router, unrouted * reuse severity/event_action validation functions in unrouted/service * reuse variables and extractions schema in router/unrouted * reuse shared conditions schema and mapping functions in router/unrouted/service * [ORCA-3486] Extend unrouted tests, add CustomizeDiff, clean shared functions (#510) * Extend unrouted tests, add CustomizeDiff, clean shared functions * Move shared functions for unrouted and service paths to utils file * orchestration and path resource documentation * datasource documentation * refactor * update comment * update type field documentation * update documentation * cleanup * Remove mention of the suppress action from event_orchestration_unrouted docs * Add "Optional" info to 1 attribute in event_orchestration_service docs * give a better datasource example * cleanup * Add Event Orchestration info to the CHANGELOG (release date TBD) (#514) * update go-pagerduty package * Router - make sets, rules, conditions singular * Unrouted, Service - make sets, rules, conditions, variables, extractions, pd_automation_actions, automations_action (headers, params) singular * Event Orchestration - make integrations singular * update Event Orchestration documentation * EO data source - retry on any error * EO data source - retry on any error Co-authored-by: Pari Dhanakoti <pdhanakoti@pagerduty.com> Co-authored-by: Alex Zakabluk <azakabluk@pagerduty.com> Co-authored-by: Marcos Wright-Kuhns <webmaster@wrightkuhns.com> Co-authored-by: Scott McAllister <smcallister@pagerduty.com>
stmcallister
pushed a commit
that referenced
this pull request
Jun 9, 2022
* ORCA-3459 - event orchestration resource * reformat * [REVERT LATER] Temporarily pointing to the local copy of go-pagerduty * rename Orchestration references to EventOrchestration * add more properties, mapping logic; add tests * more tests to event_orchestration_resource * add datasource event orchestration * [REVERT LATER]-local testing * fix create logic (set integrations), remove description and routes from orchestration data source * fix data source, add data source tests * reformat * Add import tests * update to latest alenapan/go-pagerduty * add team checks to the tests * [ORCA-3475] Allow deleting event orchestration team from an orchestration (#494) * support unsetting orch team * add retry logic to the event orchestration update method * [ORCA-3463] Orchestration Path Router Resource (#493) * router path * Add support for parent * refactor * update handler and actions support * support conditions * move conditions to util * move parent to util * test for multiple rules and conditions * actions and catchall * refactor tests * validateFunc * refactor * undo local vendor module path change * rules schema change and test * PR comments addressed * Event orchestration unrouted resource (#495) * Init commit for unrouted * Added tests for unrouted * Added catch_all to unrouted schema * Tweaked catch_all * Merge event-orchestrations * Add testacc for unrouted * Added full config test for unrouted * Add test for number of extractions and variables * Cleaned router and added new test checks to unrouted * Change escalation_policy from snake case to camel case * make type computed and set it on read/update * Orca 3486 refactor (#500) * Clean sweeper function for router/unrouted * Clean sweeper function * [ORCA-3465] - Event Orchestration Service path resource (#499) * ORCA-3465 - Event Orchestration Service Path resource * add resource file * fix read/update, add test * more tests * more service path tests, add conditions * more tests * more tests * add more service path props * fix orch path PUT payload, add tests * fix Suspend * ToDos * add catch_all support, fix tests * add support for regex extractions, add mor tests, add service path import test * update client * PR feedback * Flatten teams block (#506) * Flatten teams block * Fixed naming for the test orchestration * ORCA-3486 - remove team attribute from service path * flatten/rename parent to 'service' for service path * remove type attribute from unrouted * remove type attribute from router * flatten/rename parent to 'event_orchestration' for router * set event_orchestration attr on router import * flatten/rename parent to 'event_orchestration' for unrouted * Clean teams block * revert changes on web file * [ORCA-3486] - Reuse shared Event Orchestration Path logic, add import tests (#509) * ORCA-3486 - add import tests for router/unrouted * ORCA-3486 - add import tests for router, unrouted * reuse severity/event_action validation functions in unrouted/service * reuse variables and extractions schema in router/unrouted * reuse shared conditions schema and mapping functions in router/unrouted/service * [ORCA-3486] Extend unrouted tests, add CustomizeDiff, clean shared functions (#510) * Extend unrouted tests, add CustomizeDiff, clean shared functions * Move shared functions for unrouted and service paths to utils file * orchestration and path resource documentation * datasource documentation * refactor * update comment * update type field documentation * update documentation * cleanup * Remove mention of the suppress action from event_orchestration_unrouted docs * Add "Optional" info to 1 attribute in event_orchestration_service docs * give a better datasource example * cleanup * Add Event Orchestration info to the CHANGELOG (release date TBD) (#514) * update go-pagerduty package * Router - make sets, rules, conditions singular * Unrouted, Service - make sets, rules, conditions, variables, extractions, pd_automation_actions, automations_action (headers, params) singular * Event Orchestration - make integrations singular * update Event Orchestration documentation * EO data source - retry on any error * EO data source - retry on any error Co-authored-by: Pari Dhanakoti <pdhanakoti@pagerduty.com> Co-authored-by: Alex Zakabluk <azakabluk@pagerduty.com> Co-authored-by: Marcos Wright-Kuhns <webmaster@wrightkuhns.com> Co-authored-by: Scott McAllister <smcallister@pagerduty.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended unrouted tests with regex extractions, added CustomizeDiff and moved shared functions for service and unrouted paths to the util file.