Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Docs Bugs in pagerduty_service Ref: Issue #522 #554

Merged
merged 1 commit into from
Aug 1, 2022
Merged

Fixed Docs Bugs in pagerduty_service Ref: Issue #522 #554

merged 1 commit into from
Aug 1, 2022

Conversation

stmcallister
Copy link
Contributor

Fixed #522
Sample code issues addressed:

  • Corrected escalation policy target rule to show user_reference instead of user
  • Removed deprecated teams field from pagerduty_user
  • Fixed escalation policy reference to use correct foo name

Thanks for bringing this to our attention @ethanmsl!

imjaroiswebdev
imjaroiswebdev approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@imjaroiswebdev imjaroiswebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looking great! Thank you Scott! 🎉

@imjaroiswebdev imjaroiswebdev merged commit 07940a1 into PagerDuty:master Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imjaroiswebdev imjaroiswebdev imjaroiswebdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation Error: PagerDuty_Service
2 participants
@stmcallister @imjaroiswebdev