Print number and error for failing contact method validation #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zecke
force-pushed
the
freyth/pd-contact-method
branch
from
0e0bbc7
to
681936b
Compare
imjaroiswebdev
requested review from
imjaroiswebdev
and removed request for
drastawi
The validation is great but sometimes it is helpful to see what the input was and the error that as produced. Print the input and the error when available.
imjaroiswebdev
force-pushed
the
freyth/pd-contact-method
branch
from
681936b
to
607ca57
Compare
imjaroiswebdev
approved these changes
Apr 5, 2023
There was a problem hiding this comment.
Thank for this valuable addition @zecke, because your change was ready and I wanted to merge this PR, I took the liberty of rebasing the history for a clean merge. I really hope you don't mind that I did it ✌🏽 Once again... thank you for your contribution. 😎
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validation is great but sometimes it is helpful to see what the input was and the error that as produced. Print the input and the error when available.