Address: Service integration perm diff with Generic email and empty/omitted email_filter
#625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Provider version v2.4.0 the attribute
email_filterwas introduced topagerduty_service_integrationto enhance the configuration capabilities forgeneric_email_inbound_integrationtype, however theemail_filterresponse from PD API always returns the default values for each field of that make part of theemail_filteritself, even when this value is configured as empty or omitted from Terraform config. That said, this causes a permanent diff on the state, because the values for the empty/omittedemail_filteraren't written on the TF code.Additionally users coming from version v2.3.0 will find this diff after the update to newer versions of the Provider.
So, this update is meant to solve this permanent diff issue with
pagerduty_service_integration.email_filterattribute.New test cases introduced...