Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump terraform-plugin-sdk/v2 to solve #732 #733

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

NargiT
Copy link
Contributor

@NargiT NargiT commented Aug 24, 2023

Closes #732

In order to solve the issue I bumped github.com/hashicorp/terraform-plugin-sdk/v2 v2.11.0

I run a local version on my computer "faking" the provider.

Everything worked as expected

@imjaroiswebdev imjaroiswebdev self-requested a review August 24, 2023 17:45
Copy link
Contributor

@imjaroiswebdev imjaroiswebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏽 Thank you @NargiT for taking the time to contribute this update which will be very welcomed by rest of Terraform Provider users. 🎉 💪🏽

@imjaroiswebdev
Copy link
Contributor

I ran large set of acceptance tests and I can confirm that all is still working as expected 💯

@imjaroiswebdev imjaroiswebdev merged commit 36c11b2 into PagerDuty:master Aug 24, 2023
1 check passed
@NargiT
Copy link
Contributor Author

NargiT commented Aug 25, 2023

Excellent news, I switched to the official release 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BLOCKER: Increase terraform-plugin-sdk to 2.11.0 to unlock 4Mb limit to 256Mb
2 participants