-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/add iw inline steps inputs support #768
Feat/add iw inline steps inputs support #768
Conversation
9f2590d
to
befe99b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order for the unit tests to run without issues, please introduce a module replacement pointing to the HEAD of your version of go-pagerduty
with latest changes.
I left a few comments, which should be addressed first to proceed with merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @brandonw. Thank you! Inline Inputs enhancement to Incident Workflows will be pretty appreciated by PagerDuty Terraform provider users 🎉 🥳
a721945
to
b4cb42c
Compare
b4cb42c
to
f2f3363
Compare
This update brings support for using
inline_steps_input
s when building Incident Workflows.inline_steps_input
s are specialized inputs of certain Actions that can be identified by looking for `@metadata.format="inlineSteps".These specialized inputs diverge from the standard value format of
string
, and instead are composed of a specific schema that allows inline steps to be configured. This allows for a series of inline steps to be executed conditionally, or within a loop, while still being defined as part of a single workflow.I have also included several fixes for configured workflows with inputs that have default values, or are ordered differently from the canonical action input ordering. These changes will prevent plan diffs from always existing, even after having just applied the current config.
Test cases were extended for both IncidentWorkflow and IncidentWorkflowTrigger:
Merging depends on heimweh/go-pagerduty#141