[CSGI-2429 ] Add provider and a Standards datasource using Terraform Plugin Framework #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjgajard
force-pushed
the
tpf-datasource-standards
branch
from
8ca4852 to
7c775a5
Compare
imjaroiswebdev
changed the title
cjgajard
force-pushed
the
tpf-datasource-standards
branch
2 times, most recently
from
f703b1d to
db48975
Compare
imjaroiswebdev
requested changes
Jan 29, 2024
There was a problem hiding this comment.
Before moving forward with merging there are a few comments to address @cjgajard. Please rebase and let know for second take.
Update go version to 1.20 Add pagerdutyplugin provider and new api client Move util functions to its own module Add data source 'standards' to pagerdutyplugin/ Add acceptance test to standards datasource Add website docs for pagerduty_standards
cjgajard
force-pushed
the
tpf-datasource-standards
branch
from
db48975 to
a23818c
Compare
cjgajard
force-pushed
the
tpf-datasource-standards
branch
from
a23818c to
54b8519
Compare
imjaroiswebdev
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Great work @cjgajard! This is a very welcomed addition to the provider and its technical evolution going forward 🎉 💪🏽
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update go version to 1.20
Add pagerdutyplugin provider and Pagerduty/go-pagerduty as new api client
Move util functions to its own module
Add data source 'standards' to pagerdutyplugin/
Add acceptance test to standards datasource
Add website docs for pagerduty_standards
Depends on