Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSGI-2475] Migrate Resource pagerduty_business_service to TF Plugin Framework #808

Merged
merged 5 commits into from
Feb 23, 2024

Conversation

cjgajard
Copy link
Contributor

@cjgajard cjgajard commented Jan 26, 2024

This update is meant to migrate pagerduty_business_service resource from its current implementation using Terraform SDK v2 to Terraform Plugin Framework keeping feature parity as part of a progressive migration plan for all Terraform object in this Provider to Terraform Plugin Framework.

Acceptance Test Results...

$ make testacc TESTARGS='-run TestAccPagerDutyBusinessService'

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccPagerDutyBusinessService -timeout 120m
?       github.com/PagerDuty/terraform-provider-pagerduty       [no test files]
=== RUN   TestAccPagerDutyBusinessServiceSubscriber_import
--- PASS: TestAccPagerDutyBusinessServiceSubscriber_import (21.23s)
=== RUN   TestAccPagerDutyBusinessServiceSubscriber_User
--- PASS: TestAccPagerDutyBusinessServiceSubscriber_User (17.56s)
=== RUN   TestAccPagerDutyBusinessServiceSubscriber_Team
--- PASS: TestAccPagerDutyBusinessServiceSubscriber_Team (16.13s)
=== RUN   TestAccPagerDutyBusinessServiceSubscriber_TeamUser
--- PASS: TestAccPagerDutyBusinessServiceSubscriber_TeamUser (17.29s)
=== RUN   TestAccPagerDutyBusinessServiceDependency_Basic
--- PASS: TestAccPagerDutyBusinessServiceDependency_Basic (32.12s)
=== RUN   TestAccPagerDutyBusinessServiceDependency_Parallel
--- PASS: TestAccPagerDutyBusinessServiceDependency_Parallel (55.76s)
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/pagerduty     (cached)
?       github.com/PagerDuty/terraform-provider-pagerduty/util  [no test files]
=== RUN   TestAccPagerDutyBusinessService_import
--- PASS: TestAccPagerDutyBusinessService_import (19.36s)
=== RUN   TestAccPagerDutyBusinessService_Basic
--- PASS: TestAccPagerDutyBusinessService_Basic (20.15s)
=== RUN   TestAccPagerDutyBusinessService_WithTeam
--- PASS: TestAccPagerDutyBusinessService_WithTeam (17.48s)
=== RUN   TestAccPagerDutyBusinessService_SDKv2Compatibility
--- PASS: TestAccPagerDutyBusinessService_SDKv2Compatibility (32.34s)
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/pagerdutyplugin

@cjgajard cjgajard changed the title [CSGI-2474] Migrate Resource pagerduty_service_dependency to TF Plugin Framework [CSGI-2474] Migrate Resource pagerduty_business_service to TF Plugin Framework Feb 2, 2024
@cjgajard cjgajard marked this pull request as ready for review February 20, 2024 19:49
@imjaroiswebdev imjaroiswebdev changed the title [CSGI-2474] Migrate Resource pagerduty_business_service to TF Plugin Framework [CSGI-2475] Migrate Resource pagerduty_business_service to TF Plugin Framework Feb 20, 2024
Copy link
Contributor

@imjaroiswebdev imjaroiswebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking very good @cjgajard, however there are a few comments to address before moving forward with merge.

README.md Outdated Show resolved Hide resolved
pagerdutyplugin/resource_pagerduty_business_service.go Outdated Show resolved Hide resolved
pagerdutyplugin/resource_pagerduty_business_service.go Outdated Show resolved Hide resolved
pagerdutyplugin/resource_pagerduty_business_service.go Outdated Show resolved Hide resolved
pagerdutyplugin/resource_pagerduty_business_service.go Outdated Show resolved Hide resolved
pagerdutyplugin/resource_pagerduty_business_service.go Outdated Show resolved Hide resolved
Copy link
Contributor

@imjaroiswebdev imjaroiswebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! This is now ready to be merged! Thank you @cjgajard great job! 💪🏽 🎉

@imjaroiswebdev imjaroiswebdev merged commit 620f5d2 into PagerDuty:master Feb 23, 2024
1 check passed
@cjgajard cjgajard deleted the tpf-business-service branch February 27, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants