fix(team membership): Allow 404 to propagate to avoid registering it in disassociated eps list #838
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to a bug where when deleting team membership you can get errors when the same user exists in other teams escalation policies (due to the fact that it will try to reattach all the EP's to the team, even when getting 404 error).
TLDR, Line 289 will never get hit if we keep that logic in place.
Acceptance test results...