Address: 403 Forbidden error when updating existing pagerduty_escalation_policy's target #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjgajard
approved these changes
Apr 5, 2024
imjaroiswebdev
force-pushed
the
issue-819-403-querying-ep
branch
from
432ba9b to
711972f
Compare
cjgajard
approved these changes
Apr 5, 2024
|
Tried out the latest release (3.11.1) and am still having this issue unfortunately, still getting 403 Forbidden on the PUT request for updating the targets. Terraform version: 1.5.1 |
rawmind0
reviewed
Apr 8, 2024
| } | ||
|
|
||
| if err == nil && escalationPolicyFirstAttempt == nil { | ||
| return setResourceEPProps(d, escalationPolicyFirstAttempt) |
There was a problem hiding this comment.
This seems wrong, should be if err == nil && escalationPolicyFirstAttempt != nil { instead of if err == nil && escalationPolicyFirstAttempt == nil { due to setResourceEPProps(d *schema.ResourceData, escalationPolicy *pagerduty.EscalationPolicy) function is not checking if escalationPolicy is nil.
|
Same here. Fix didn't help. Still getting 403 |
vorotech
added a commit
to trustwallet/terraform-provider-pagerduty
that referenced
this pull request
Apr 10, 2024
Fix is suggested in comments to PagerDuty#846
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #819