Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Incident Workflow triggers team restrictions #861

Conversation

imjaroiswebdev
Copy link
Contributor

@imjaroiswebdev imjaroiswebdev commented Apr 22, 2024

Closes #848

Depends on heimweh/go-pagerduty#150 for merging

New test cases introduced...

$ PAGERDUTY_ACC_INCIDENT_WORKFLOWS=1 make testacc TESTARGS='-run TestAccPagerDutyIncidentWorkflowTrigger'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccPagerDutyIncidentWorkflowTrigger -timeout 120m
?       github.com/PagerDuty/terraform-provider-pagerduty       [no test files]
=== RUN   TestAccPagerDutyIncidentWorkflowTrigger_import
--- PASS: TestAccPagerDutyIncidentWorkflowTrigger_import (23.94s)
=== RUN   TestAccPagerDutyIncidentWorkflowTrigger_BadType
--- PASS: TestAccPagerDutyIncidentWorkflowTrigger_BadType (2.90s)
=== RUN   TestAccPagerDutyIncidentWorkflowTrigger_ConditionWithManualType
--- PASS: TestAccPagerDutyIncidentWorkflowTrigger_ConditionWithManualType (2.87s)
=== RUN   TestAccPagerDutyIncidentWorkflowTrigger_ConditionalTypeWithoutCondition
--- PASS: TestAccPagerDutyIncidentWorkflowTrigger_ConditionalTypeWithoutCondition (2.84s)
=== RUN   TestAccPagerDutyIncidentWorkflowTrigger_SubscribedToAllWithInvalidServices
--- PASS: TestAccPagerDutyIncidentWorkflowTrigger_SubscribedToAllWithInvalidServices (2.84s)
=== RUN   TestAccPagerDutyIncidentWorkflowTrigger_BasicManual
--- PASS: TestAccPagerDutyIncidentWorkflowTrigger_BasicManual (20.81s)
=== RUN   TestAccPagerDutyIncidentWorkflowTrigger_BasicConditionalAllServices
--- PASS: TestAccPagerDutyIncidentWorkflowTrigger_BasicConditionalAllServices (20.13s)
=== RUN   TestAccPagerDutyIncidentWorkflowTrigger_ManualWithTeamPermissions  # 👈 New Acceptance Test
--- PASS: TestAccPagerDutyIncidentWorkflowTrigger_ManualWithTeamPermissions (39.13s)
=== RUN   TestAccPagerDutyIncidentWorkflowTrigger_ChangeTypeCausesReplace
--- PASS: TestAccPagerDutyIncidentWorkflowTrigger_ChangeTypeCausesReplace (22.06s)
=== RUN   TestAccPagerDutyIncidentWorkflowTrigger_CannotChangeType
--- PASS: TestAccPagerDutyIncidentWorkflowTrigger_CannotChangeType (21.34s)
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/pagerduty     160.056s
testing: warning: no tests to run
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/pagerdutyplugin       1.353s [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/util  0.479s [no tests to run]

@imjaroiswebdev imjaroiswebdev force-pushed the issue-848-support-iw-permissions branch from 24555a4 to a95c827 Compare April 23, 2024 23:38
go.mod Outdated Show resolved Hide resolved
@imjaroiswebdev imjaroiswebdev merged commit 5211b7e into PagerDuty:master May 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request - Missing support for manual Incident Workflows trigger team restriction
2 participants