Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow resource extension's endpoint_url to be imported as null #880

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

cjgajard
Copy link
Contributor

@cjgajard cjgajard commented Jun 11, 2024

Closes #869

Acceptance tests introduced...

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -count=1 -run TestAccPagerDutyExtension_import -timeout 120m
?       github.com/PagerDuty/terraform-provider-pagerduty       [no test files]
testing: warning: no tests to run
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/pagerduty     0.541s [no tests to run]
=== RUN   TestAccPagerDutyExtension_import
--- PASS: TestAccPagerDutyExtension_import (19.72s)
=== RUN   TestAccPagerDutyExtension_import_WithoutEndpointURL # 👈 New acceptance introduce to protect from a regression
--- PASS: TestAccPagerDutyExtension_import_WithoutEndpointURL (24.18s)
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/pagerdutyplugin       44.780s
testing: warning: no tests to run
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/util  0.625s [no tests to run]

Copy link
Contributor

@imjaroiswebdev imjaroiswebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪🏽 🎉 Thank you @cjgajard

@imjaroiswebdev imjaroiswebdev merged commit 664e8ca into PagerDuty:master Jun 12, 2024
1 check passed
@cjgajard cjgajard deleted the fix/endpoint_url branch June 17, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.endpoint_url: inconsistent values for sensitive in v3.12.0
2 participants