Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore import state verification for EO routing rules ids #883

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

imjaroiswebdev
Copy link
Contributor

@imjaroiswebdev imjaroiswebdev commented Jun 13, 2024

Acceptance test results after patching...

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -count=1 -run TestAccPagerDutyEventOrchestrationPathRouter_import -timeout 120m
?       github.com/PagerDuty/terraform-provider-pagerduty       [no test files]
?       github.com/PagerDuty/terraform-provider-pagerduty/util/apiutil  [no test files]
=== RUN   TestAccPagerDutyEventOrchestrationPathRouter_import
--- PASS: TestAccPagerDutyEventOrchestrationPathRouter_import (15.98s)
PASS
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -count=1 -run TestAccPagerDutyEventOrchestrationPathUnrouted_import -timeout 120m
?       github.com/PagerDuty/terraform-provider-pagerduty       [no test files]
?       github.com/PagerDuty/terraform-provider-pagerduty/util/apiutil  [no test files]
=== RUN   TestAccPagerDutyEventOrchestrationPathUnrouted_import
--- PASS: TestAccPagerDutyEventOrchestrationPathUnrouted_import (12.95s)
PASS

@imjaroiswebdev imjaroiswebdev requested a review from alenapan June 13, 2024 22:45
Copy link
Contributor

@alenapan alenapan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imjaroiswebdev thank you for fixing it! I also had ImportStateVerifyIgnore in mind but wasn't sure if it's safe to ignore the mismatching properties. Do you know by any chance why TestAccPagerDutyEventOrchestrationPathGlobal_import tests are passing despite the fact that rule IDs are also computed?

I also noticed that TestAccPagerDutyEventOrchestrationPathService_import is failing because of the mismatch in the enable_event_orchestration_for_service values. While you are on the branch, could you add ImportStateVerifyIgnore: []string{"enable_event_orchestration_for_service"}, to that test as well? I'm not sure if I'd have the permission to push to this branch.

Copy link
Contributor

@alenapan alenapan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you again for fixing it!

@imjaroiswebdev imjaroiswebdev merged commit 29e6717 into PagerDuty:master Jun 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants