Add support for Jira Cloud integration #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imjaroiswebdev
requested changes
Oct 28, 2024
There was a problem hiding this comment.
@cjgajard great job so far. Please address the comments I left, for us to move forward with the merge.
pagerdutyplugin/resource_pagerduty_jira_cloud_account_mapping_rule_test.go
Show resolved
Hide resolved
pagerdutyplugin/resource_pagerduty_jira_cloud_account_mapping_rule.go
Outdated
Show resolved
Hide resolved
pagerdutyplugin/resource_pagerduty_jira_cloud_account_mapping_rule_test.go
Show resolved
Hide resolved
cjgajard
force-pushed
the
tpf-jira
branch
4 times, most recently
from
0898799
to
4b4dd9b
Compare
Add data source for Jira Cloud account mapping Add resource for Jira Cloud account mapping rule Update dependency to PagerDuty/go-pagerduty module Fix Document PAGERDUTY_ACC_JIRA_ACCOUNT_MAPPING_ID Fix Jira Cloud accounts mapping Update in vendor/
imjaroiswebdev
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add data source for Jira Cloud account mapping
Add resource for Jira Cloud account mapping rule