Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alias deg for ° #764

Closed
wants to merge 0 commits into from
Closed

Conversation

fhagemann
Copy link

Some packages are already defining the alias deg for Unitful.°, so I wanted to trigger some discussion whether it would be feasible to include the alias deg for ° into Unitful.
If not, feel free to close this PR again.

test/runtests.jl Outdated
@@ -2288,6 +2288,8 @@ end
@test (1//2)Unitful.ϵ0 === (1//2)Unitful.ε0
@test Unitful.Å === Unitful.angstrom
@test 1.0Unitful.Å === 1.0Unitful.angstrom
@test Unitful.deg === Unitful.°
@test 2Unitful.° === 2Unitful.deg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a test to ensure u"deg" also works?

@fhagemann
Copy link
Author

If was not too clever to start the PR from the master branch of my fork, so I reopened this PR as #770

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants