Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding Aqua credentials to aws secret manager #1043

Merged
merged 4 commits into from
Jun 26, 2023
Merged

feat: Adding Aqua credentials to aws secret manager #1043

merged 4 commits into from
Jun 26, 2023

Conversation

mahidharrajujalumuru
Copy link
Contributor

Description

Persist Aqua sensitive information in AWS secret manager

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Add new aqua account in Dev
  • Tested By retrieving the credentials and collect aqua vulnerabilities

Checklist:

  • My code follows the style guidelines of this project
  • My commit message/PR follows the contribution guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

santhosh-challa
santhosh-challa approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@santhosh-challa santhosh-challa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@sonarcloud
Copy link

sonarcloud bot commented Apr 12, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

0.0% 0.0% Coverage
26.1% 26.1% Duplication

@santhosh-challa santhosh-challa merged commit 59d91b5 into master Jun 26, 2023
@santhosh-challa santhosh-challa deleted the aqua_aws_secretmanager branch June 26, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santhosh-challa santhosh-challa santhosh-challa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mahidharrajujalumuru @santhosh-challa