fix : update notification-invoke-service to accept list of notificati… #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnithinpaladin
approved these changes
Apr 20, 2023
santhosh-challa
approved these changes
Apr 20, 2023
…ons or single notification in the payload
raviteja-mandala
force-pushed
the
fix/update-send-notification-service-to-accept-single-event
branch
from
a41e73b
to
1d4c851
Compare
|
SonarCloud Quality Gate failed. |
santhosh-challa
deleted the
fix/update-send-notification-service-to-accept-single-event
branch
plyubich
reviewed
Apr 21, 2023
|
|
||
| Object payloadObj = gson.fromJson(payloadString,Object.class); | ||
| if(payloadObj instanceof List){ | ||
| List<Object> notificationRequestList = gson.fromJson(payloadString,List.class); |
There was a problem hiding this comment.
@raviteja-mandala @santhosh-challa this line is an error. when sending a object (not an array of events), the code falls through the first if and considers the object to be a list as well
plyubich
reviewed
Apr 21, 2023
| @@ -40,6 +40,26 @@ public String handleRequest(Map<String,Object> event, Context context) | |||
| System.out.println("bodyJson--"+bodyJson.toString()); | |||
| payloadString = bodyJson.getAsJsonObject().get("Sns").getAsJsonObject().get("Message").getAsString(); | |||
| } | |||
|
|
|||
| Object payloadObj = gson.fromJson(payloadString,Object.class); | |||
| if(payloadObj instanceof List){ | |||
There was a problem hiding this comment.
this line here is what allowing the single events to fall through here. This "if" statement is not working as intended for single objects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ons or single notification in the payload
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List
any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also
list any relevant details for your test configuration
Checklist:
Other information:
List any documentation updates that are needed for the Wiki