Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): corrected lodash imports #1271

Merged

Conversation

astra1
Copy link
Contributor

@astra1 astra1 commented Jun 5, 2023

Description

Proper lodash imports saves around 40KB of webapp bundle size

before:

Initial Chunk Files Names Raw Size Estimated Transfer Size
main.f1e71483bf9d174f.js main 6.25 MB 1.06 MB

after:

Initial Chunk Files Names Raw Size Estimated Transfer Size
main.6c25a8eb39a0df48.js main 6.21 MB 1.04 MB

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also
list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • My commit message/PR follows the contribution guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Other information:

List any documentation updates that are needed for the Wiki

@santhosh-challa santhosh-challa merged commit 88dc592 into PaladinCloud:master Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants