Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced deprecated tslint with eslint, introduced prettier, editorconfig & stylelint #791

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

astra1
Copy link
Contributor

@astra1 astra1 commented Feb 6, 2023

Description

As angular frontend project uses the obsolete tslint dependency, it has been replaced by eslint. Added prettier for code formatting. CSS styles are now validated using stylelint.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also
list any relevant details for your test configuration

  • cd webapp && npm run lint
  • cd webapp && npm run lint:styles

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The commit message/PR follows our guidelines

Other information:

airbnb typescript eslint rules
editorconfig
used prettier as formatter
introduced stylelint for css linting
added recommended extensions to vscode workspace
@plyubich
Copy link
Contributor

Looks good

Copy link
Contributor

@plyubich plyubich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We should follow the new eslint style and reformat the code using prettier settings in the future

Copy link
Contributor

@ranadheer-b ranadheer-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@santhosh-challa santhosh-challa merged commit d2c1214 into PaladinCloud:master Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants