Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:removing accounts from rule params #863

Merged
merged 6 commits into from
Feb 24, 2023
Merged

feat:removing accounts from rule params #863

merged 6 commits into from
Feb 24, 2023

Conversation

AishwaryaKulkarni97
Copy link
Contributor

Description

Taking accounts from sql database instead of rule params

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also
list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The commit message/PR follows our guidelines

Other information:

@sonarcloud
Copy link

sonarcloud bot commented Feb 24, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
11.0% 11.0% Duplication

@AishwaryaKulkarni97 AishwaryaKulkarni97 merged commit 745be2e into master Feb 24, 2023
@AishwaryaKulkarni97 AishwaryaKulkarni97 deleted the feat/accountsRDS branch February 24, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dheerajkholia-paladin dheerajkholia-paladin dheerajkholia-paladin approved these changes

@santhosh-challa santhosh-challa santhosh-challa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AishwaryaKulkarni97 @santhosh-challa @dheerajkholia-paladin