Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useWebSocket is ignored #3

Closed
miyconst opened this issue Mar 1, 2016 · 9 comments
Closed

useWebSocket is ignored #3

miyconst opened this issue Mar 1, 2016 · 9 comments
Labels
bug
Milestone
PALF Palindrom st...

Comments

@miyconst
Copy link

miyconst commented Mar 1, 2016 

<puppet-client use-web-socket="false" usewebsocket="false" ref="root"></puppet-client>

Still uses WebSocket for communication.
@miyconst miyconst added the bug label Mar 1, 2016
This was referenced Mar 3, 2016
Closed
Closed
@miyconst
Copy link
Author

miyconst commented May 6, 2016

@warpech could you please fix it?

There is a bug in Chrome, which causes an error when using WS.
http://stackoverflow.com/questions/37066865/one-or-more-reserved-bits-are-on-reserved1-0-reserved2-1-reserved3-1

@warpech warpech mentioned this issue May 23, 2016
Closed
@warpech warpech self-assigned this May 24, 2016
@warpech
Copy link
Contributor

warpech commented May 24, 2016

This should be auto-fixed with #9

@warpech warpech assigned joozek78 and unassigned warpech May 25, 2016
@miyconst
Copy link
Author

miyconst commented Jun 2, 2016

No, it's not fixed. @joozek78 please fix it.

@warpech
Copy link
Contributor

warpech commented Jun 2, 2016

Yeah, I meant it should be automatically fixed if #9 is accepted and merged, which it was not yet. Palindrom/Palindrom#85 has bigger priority than this now

@warpech
Copy link
Contributor

warpech commented Jun 24, 2016

@joozek78 now that we decided to abandon #9, this issue needs to be fixed properly. pupper-polymer-client needs to wrap puppet. useWebSocket property.

When this is fixed, the "Use WebSocket" checkbox in starcounter-debug-aid will start to function again.

@joozek78
Copy link
Contributor

This is actually caused by how Polymer properties work. Take a look at this thread. There's even a work-around proposed there

@joozek78 joozek78 removed their assignment Aug 8, 2016
@warpech
Copy link
Contributor

warpech commented Oct 2, 2017

Check if this is still relevant in the Polymer 2.0 version.

@warpech warpech added this to the Palindrom stability milestone Apr 7, 2018
warpech added a commit that referenced this issue Jun 26, 2019
@warpech
new features: default value for remoteUrl and boolean attribute conve…
d6def31 
…rsion (#3)

- default value for remoteUrl was requested here: Palindrom/Palindrom#247
- boolean attribute conversion is needed for fixing the Polymer demo page in the docs: http://localhost:5000/lab/polymer/index.html. This also fixes the issue #3

Both changes have tests
@warpech warpech mentioned this issue Jun 26, 2019
Merged
@warpech
Copy link
Contributor

warpech commented Jun 26, 2019

The correct attribute name is use-web-socket. There is indeed problem with converting attribute values to booleans. The fix is in PR #84

@warpech
Copy link
Contributor

warpech commented Jun 28, 2019

Fixed in #84

@warpech warpech closed this as completed Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
PALF Palindrom stability
Development

No branches or pull requests
3 participants
@warpech @joozek78 @miyconst